Skip to content

Conversation

@tvdijen
Copy link
Member

@tvdijen tvdijen commented Dec 4, 2023

No description provided.

@tvdijen tvdijen force-pushed the library branch 3 times, most recently from 5bf25f4 to cc89363 Compare December 4, 2023 23:35
@tvdijen tvdijen force-pushed the library branch 2 times, most recently from 0d7f437 to 65dc53f Compare April 14, 2025 21:05
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

❌ Patch coverage is 53.90625% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.00%. Comparing base (d20d255) to head (ae2ce00).
⚠️ Report is 31 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master       #7       +/-   ##
=============================================
+ Coverage     18.18%   50.00%   +31.81%     
- Complexity       30       56       +26     
=============================================
  Files             2        2               
  Lines           121      198       +77     
=============================================
+ Hits             22       99       +77     
  Misses           99       99               
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tvdijen tvdijen force-pushed the library branch 2 times, most recently from bea40d8 to 079b2a8 Compare April 14, 2025 21:25
@tvdijen tvdijen force-pushed the library branch 3 times, most recently from 6bc5f0f to 46df935 Compare July 7, 2025 22:01
@tvdijen tvdijen force-pushed the library branch 2 times, most recently from a607035 to 2b3534f Compare October 29, 2025 16:50
@tvdijen
Copy link
Member Author

tvdijen commented Dec 15, 2025

Shall we merge @ioigoume ?

@ioigoume
Copy link
Contributor

Shall we merge @ioigoume ?

@tvdijen not yet. I want to run more tests tomorrow morning and i will ping you.

@tvdijen
Copy link
Member Author

tvdijen commented Dec 15, 2025

I don't want to put everything into one PR, but we should try and use symfony/http-client instead of \SimpleSAML\Utils\HTTP::*

@tvdijen tvdijen merged commit 44a79b9 into master Dec 17, 2025
44 checks passed
@tvdijen tvdijen deleted the library branch December 17, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants