Skip to content

Conversation

@ioigoume
Copy link
Contributor

@ioigoume ioigoume commented Jan 8, 2026

Upgrade ldap module to version 2.5. Updated documentation to match the new configuration. Added tests. Fixed the ldap integration code.

@ioigoume ioigoume requested a review from tvdijen January 8, 2026 10:21
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.21%. Comparing base (5599da1) to head (fbc1432).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #14       +/-   ##
=============================================
+ Coverage     50.00%   71.21%   +21.21%     
- Complexity       56       58        +2     
=============================================
  Files             2        2               
  Lines           198      198               
=============================================
+ Hits             99      141       +42     
+ Misses           99       57       -42     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ioigoume ioigoume force-pushed the ldap-module-upgrade branch from 6bc3891 to b0b0659 Compare January 8, 2026 10:25
@tvdijen
Copy link
Member

tvdijen commented Jan 8, 2026

That seems like it was much easier than I had anticipated! Great job @ioigoume !

@ioigoume ioigoume force-pushed the ldap-module-upgrade branch from b0b0659 to 0d24577 Compare January 8, 2026 14:14
…e new configuration. Added tests. Fixed the ldap integration code.
@ioigoume ioigoume force-pushed the ldap-module-upgrade branch from 0d24577 to fbc1432 Compare January 8, 2026 14:19
@ioigoume ioigoume merged commit bd1bebf into simplesamlphp:master Jan 9, 2026
21 checks passed
@ioigoume ioigoume deleted the ldap-module-upgrade branch January 9, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants