Remove inspec-based acceptance tests for EL7#214
Merged
Conversation
EL7 is no longer supported and the upstream inspec-profile-disa_stig-el7 repository is unmaintained, so the fixture and its acceptance suite no longer provide useful coverage. Also drops the leftover inspec hack from the STIG enforcement spec, which only existed to seed profile fixtures for the inspec run. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This compliance-suite nodeset only declared an EL7 host named `el7-auditd-inspec` and was not referenced anywhere else. With EL7 support and the inspec acceptance tests gone, it has no remaining use; the suite still falls back to the adjacent default.yml nodeset. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
With the inspec-based tests gone, what remained in the compliance suite was a STIG enforcement test that drives Hiera through `compliance_markup::enforcement`. Recent cleanup removed the `compliance_markup` fixture (see "Remove unmaintained Compliance Engine data"), so the lookup_key function is no longer loaded during the test and the suite cannot run. The default nodeset is also EL7-pinned, which is no longer supported. Any OSCAP/SSG specs in the suite are EL7-pinned and either already pending or otherwise unused, so they are dropped along with the rest. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
silug
changed the title
michael-riddle
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EL7 is no longer supported and the upstream inspec-profile-disa_stig-el7 repository is unmaintained, so the fixture and its acceptance suite no longer provide useful coverage. Also drops the leftover inspec hack from the STIG enforcement spec, which only existed to seed profile fixtures for the inspec run.