fix(font): embed Symbols Nerd Font Mono fallback for Nerd Font PUA icons#8
Merged
Merged
Conversation
The sidebar's own UI draws Nerd Font private-use-area glyphs (status dot U+F111 nf-fa-circle, project icons U+E5FF/U+E7A8/... from icon_glyph), but on a machine with no Nerd Font family installed nothing in the fallback chain can resolve PUA codepoints — name-list discovery and all_families() find no candidate, and the CoreText cascade cannot map private-use codepoints — so the sidebar rendered tofu boxes. Vendor Symbols Nerd Font Mono (v3.4.0, MIT, symbols-only — no Latin/CJK letterforms) into noa-font and embed it via include_bytes! as a permanent fallback face, mirroring Ghostty's bundled-font coverage guarantee. Stack order: emoji, installed Nerd Fonts (user's choice keeps winning), embedded Symbols, CJK — so PUA never resolves to a CJK private glyph and the embedded face can never shadow a face that actually covers a codepoint. The face rides the existing is_icon_fallback_face styling/sizing path. FontBytes gains a Static variant since the embedded bytes are already resident (no heap copy, no mmap). Terminal-grid Nerd Font glyphs (e.g. starship/p10k prompts) gain the same guarantee. session-sidebar.md NFR-5/AC-21/A1 revised: tofu is no longer the accepted degradation for missing Nerd Fonts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
U+F111nf-fa-circle, project iconsU+E5FF/U+E7A8/… fromicon_glyph), but on a machine with no Nerd Font family installed they rendered as tofu boxes: name-list discovery andall_families()find no candidate, and the CoreText cascade cannot map private-use codepoints (reported via annotated screenshot, sidebar card header).crates/noa-font/vendor/ATTRIBUTION.md) and embed it viainclude_bytes!as a permanent fallback face, mirroring Ghostty's bundled-font coverage guarantee.is_icon_fallback_faceicon sizing/styling path (fix(font): align fallback styling and glyph sizing with Ghostty #6).docs/specs/session-sidebar.mdNFR-5/AC-21/A1 revised: tofu is no longer the accepted degradation for missing Nerd Fonts.Test plan
sidebar_icon_codepoints_resolve_without_installed_nerd_font— realload_font_stackresolves all 8 sidebar PUA codepoints to non-notdef glyphs, deliberately without the skip-if-font-absent pattern (that absence is the case under test).embedded_symbols_font_is_classified_icon_fallback_face.noaon a machine without any Nerd Font — sidebar dot + project icons render (was: tofu boxes).