feat(app): support JPEG and WebP background images#4
Merged
Conversation
Dispatch background-image decoding on magic bytes (PNG/JPEG/WebP) via pure-Rust zune-jpeg and image-webp decoders, and widen the slideshow candidate filter to .jpg/.jpeg/.webp.
image-webp's default memory limit is usize::MAX, so a WebP declaring a huge canvas could OOM-abort before the decode-error path runs; zune-jpeg similarly allows up to 16384x16384. Gate both on the png crate's default 64 MiB allocation limit before any buffer is allocated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
background-imagenow accepts JPEG and WebP in addition to PNG, dispatching on magic bytes to pure-Rust decoders (zune-jpeg,image-webp) — noimagecrate dependency.jpg/.jpeg/.webp(case-insensitive); unsupported/broken files are skipped per existing bad-path handlingpngcrate's default limit) before allocation, so a hostile/huge JPEG or WebP degrades to a warn + disabled image instead of OOM-abortingTest plan
cargo test -p noa-app— 791 passed (new: 1x1 JPEG/WebP fixture decode, extension filter, 64 MiB gate boundary)cargo clippy -p noa-app/cargo build --workspaceclean