Bugfix: Fix Compute Crossing Time#165
Merged
Grochocinski merged 2 commits intomasterfrom Jul 25, 2025
Merged
Conversation
Grochocinski
added a commit
that referenced
this pull request
Jul 25, 2025
- Rolled compute_crossing_time() back to linear-search approach since y-values aren't guaranteed to be in sorted order and thus binary search cannot be used to find the first occurence of data above a certain threshold. --------- Co-authored-by: Cen Wang <cenwang@umass.edu>
Grochocinski
added a commit
that referenced
this pull request
Jul 25, 2025
- Rolled compute_crossing_time() back to linear-search approach since y-values aren't guaranteed to be in sorted order and thus binary search cannot be used to find the first occurence of data above a certain threshold. --------- Co-authored-by: Cen Wang <cenwang@umass.edu>
Grochocinski
added a commit
that referenced
this pull request
Aug 22, 2025
* split script into different code blocks * migrate data farming model demo to notebook * moved demo files into ipynb blocks * fixed imports, added markdown titles * fixed post-normalized experiments not being saved * fixed uninitialized values * added class_type flag to model design creation call * reorganized file to improve flow and reduce repeated logic * Fixed Invalid Type Passing, Infinite Loop when Saving Plots (#164) * fixed infinite loop due to invalid existing file checks * fixed strings being passed to plot_type arg instead of PlotType enums * removed print statement * Bugfix: Fix Compute Crossing Time (#165) - Rolled compute_crossing_time() back to linear-search approach since y-values aren't guaranteed to be in sorted order and thus binary search cannot be used to find the first occurence of data above a certain threshold. --------- * added guard logic for negative yerr coords in scatterplots * reformatted to match san-sscont-ironore notebook * reformatted to reduce repeated logic * ported updated utils and list directory script from dev_traffic_light (#167) * broke apart large code blocks, updated setup * cleared output with nbstripout * fix spelling mistakes * expanded enum names to match respective descriptions * fixed line length warnings * Improve logging warning for invalid error bar coordinates Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixed line length warnings --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.