fix: add follow_redirects and timeout to URL attachment fetching#1421
Open
mitre88 wants to merge 1 commit into
Open
fix: add follow_redirects and timeout to URL attachment fetching#1421mitre88 wants to merge 1 commit into
mitre88 wants to merge 1 commit into
Conversation
URL-based attachments were failing on redirects or hanging on slow connections because httpx.get/head lacked explicit parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds follow_redirects=True and timeout=30.0 to httpx.get and httpx.head in Attachment.content_bytes() and resolve_type(), preventing hangs and redirect failures when loading remote images via URL.