Add params to add full text search and drop unwanted columns#73
Open
wragge wants to merge 1 commit intosimonw:mainfrom
Open
Add params to add full text search and drop unwanted columns#73wragge wants to merge 1 commit intosimonw:mainfrom
wragge wants to merge 1 commit intosimonw:mainfrom
Conversation
|
Would love to see fts functionality merged |
| try: | ||
| db[bit].enable_fts(fts_cols.split(",")) | ||
| except sqlite3.OperationalError: | ||
| print("Column not found") |
Contributor
There was a problem hiding this comment.
I wonder if an f-string would be more appropriate to get the column names?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't know if you want to include this, but I'm finding it handy in my own fork, so I thought I'd submit it for consideration.
This pull request adds two new url parameters:
fts: column/s that you want to have a full text index (multiple values separated by commas)drop: column/s that you want to drop from the db (multiple values separated by commas)For example, this url opens a CSV dataset with oral history metadata, indexes the
titlecolumn, and drops thepublishercolumn: https://glam-workbench.net/datasette-lite/?csv=https://github.com/GLAM-Workbench/trove-oral-histories-data/blob/main/trove-oral-histories.csv&fts=title&drop=publisherSee also my GLAM Workbench Datasette-Lite fork.