accept "binary/octet-stream" content-type#72
Open
ryan-williams wants to merge 1 commit intosimonw:mainfrom
Open
accept "binary/octet-stream" content-type#72ryan-williams wants to merge 1 commit intosimonw:mainfrom
ryan-williams wants to merge 1 commit intosimonw:mainfrom
Conversation
Contributor
|
You can override the mime type header for pre-signed URL's in AWS S3 s3.generate_presigned_url(
"get_object",
Params={
"Bucket": "my-bucket",
"Key": "file.ext",
"ResponseContentType": "application/octet-stream"
},
ExpiresIn=3600
)This would bypass the non-standard header you are getting. |
| "application/octet-stream", | ||
| "application/x-sqlite3", | ||
| "application/vnd.sqlite3", | ||
| "binary/octet-stream", |
Contributor
There was a problem hiding this comment.
being able to override this if you host you own instance doesnt seem like the worlds worst option either. If the PR were to pivot to that, I think it would make datasette-lite more pluggable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 defaults (some?) files to
content-type: binary/octet-stream, and datasette-lite was giving a cryptic "That url could not be loaded" alert.This adds
binary/octet-streamto the list of recognized content-types, as well as aconsole.warnwhen an unrecognized content-type is encountered.