Skip to content

Fix det cal hwpss#1488

Merged
ykyohei merged 6 commits intomasterfrom
fix_det_cal_hwpss
Jan 6, 2026
Merged

Fix det cal hwpss#1488
ykyohei merged 6 commits intomasterfrom
fix_det_cal_hwpss

Conversation

@ykyohei
Copy link
Copy Markdown
Contributor

@ykyohei ykyohei commented Dec 8, 2025

This PR fixes issues found when I ran det_cal with hwpss subtraction for all the old observations.

  1. Inconsistent number of channels between raw biasstep npy file and L3 oper book. -> updated load_and_reanalyze_bs to load fixed tones and reindex axismanager.
  2. smurfgaps in biases leads to incorrect bias edges. -> Added correction in fill_zeros_biases
  3. Check if data of tones is None or not to debug the error of loading fixed tones. Resolves data of tones are sometimes None #1508

@ykyohei ykyohei requested review from msilvafe and tdalford December 8, 2025 14:07
Comment thread sotodlib/site_pipeline/update_det_cal.py Outdated
@ykyohei
Copy link
Copy Markdown
Contributor Author

ykyohei commented Jan 5, 2026

Additional modifications of handling of fixed tone are done and this PR is again ready to review.
I tested this for backfilling det_cal_hwpss for old observations.
I modified load_book.py to debug #1508. I would appreciate if @kmharrington could take a look at this point.

@ykyohei ykyohei requested a review from kmharrington January 5, 2026 14:04
@ykyohei ykyohei merged commit c8ec632 into master Jan 6, 2026
5 checks passed
@ykyohei ykyohei deleted the fix_det_cal_hwpss branch January 6, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

data of tones are sometimes None

3 participants