Skip to content

When starting a task/process, suppress params where value is null #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhasself merged 1 commit into from
Nov 12, 2025
Merged

When starting a task/process, suppress params where value is null #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/ocsbow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,25 @@ AgentClient.prototype = {
// These functions should be used when working with the task/proc API.
//

_clean_params : function(params) {
// Before passing params to a task/process start method, strip off
// any entries that have value = null.
//
// It is almost always the case that passing a param value of None
// (null) has the same effect as not passing the param at all.
// Unless a param is defined with "treat_none_as_missing=False",
// that will be the case. So to minimize compatibility problems
// due to new (but empty) parameters in ocs-web conflicting with
// older agents, we strip off any params with null values.
return Object.entries(params).reduce((acc, [key, value]) => {
if (value !== null)
acc[key] = value;
return acc;
}, {});
},

start_task : function(task_name, params) {
return this.dispatch('start', task_name, params);
return this.dispatch('start', task_name, this._clean_params(params));
},

wait_task : function(task_name, params) {
Expand Down Expand Up @@ -368,7 +385,7 @@ AgentClient.prototype = {
},

start_proc : function(proc_name, params) {
return this.dispatch('start', proc_name, params);
return this.dispatch('start', proc_name, this._clean_params(params));
},

stop_proc : function(proc_name) {
Expand Down