Revert band_name model field change; remove assertion from test instead#11
Merged
Revert band_name model field change; remove assertion from test instead#11
band_name model field change; remove assertion from test instead#11Conversation
Co-authored-by: JBorrow <7839515+JBorrow@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix type check issues in lightcurvedb storage
Fix all Mar 11, 2026
ty check errors in lightcurvedb/storage/postgres
Member
|
Now that is fixed, please apply the new pattern (i.e. with the |
Co-authored-by: JBorrow <7839515+JBorrow@users.noreply.github.com>
Copilot
AI
changed the title
Fix all
Apply Mar 11, 2026
ty check errors in lightcurvedb/storage/postgresPostgresPoolUser pool pattern to timescale/ storage and fix pooler typing
Co-authored-by: JBorrow <7839515+JBorrow@users.noreply.github.com>
Copilot
AI
changed the title
Apply
Apply PostgresPoolUser pool pattern to timescale/ storage; fix pre-existing test failures
Mar 11, 2026
PostgresPoolUser pool pattern to timescale/ storage and fix pooler typing…read Co-authored-by: JBorrow <7839515+JBorrow@users.noreply.github.com>
Copilot
AI
changed the title
Apply PostgresPoolUser pool pattern to timescale/ storage; fix pre-existing test failures
Fix failing tests: FeedResult.band_name field and cutout test key lookup
Mar 11, 2026
Copilot stopped work on behalf of
JBorrow due to an error
March 11, 2026 17:50
Co-authored-by: JBorrow <7839515+JBorrow@users.noreply.github.com>
Copilot
AI
changed the title
Fix failing tests: FeedResult.band_name field and cutout test key lookup
Revert Mar 11, 2026
band_name model field change; remove assertion from test instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous commit converted
FeedResult.band_namefrom a@propertyto a Pydantic model field to satisfy a type checker, but the correct fix is to remove the test assertion rather than alter the model.Changes
models/feed.py: Restoredband_nameas a computed@propertyreturningf"f{self.frequency}"client/feed.py: Removed the now-unnecessary explicitband_name=f"f{frequency}"fromFeedResultconstructiontests/test_backend/test_feed.py: Droppedassert feed.band_name == "f145"— the property is an implementation detail, not a contract worth asserting in integration testsOriginal prompt
Created from VS Code.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.