Conversation
Member
|
Just checking that this is ready for review and you're not just pushing your code up. |
Collaborator
Author
Thanks for checking. Yes, this is ready for review. |
JBorrow
reviewed
Aug 22, 2025
Member
JBorrow
left a comment
JBorrow
left a comment
There was a problem hiding this comment.
A few comments on this that would need to be addressed before a merge.
|
|
||
| class CompletedTransfer(db.Base): | ||
| """ | ||
| Class's information will be added here! |
Collaborator
Author
|
Thanks for the detailed feedbacks. I have pushed up a new commit that addresses all the comments. Let me know there is anything else! |
JBorrow
reviewed
Aug 28, 2025
JBorrow
reviewed
Aug 28, 2025
JBorrow
reviewed
Aug 28, 2025
iparask
reviewed
Sep 4, 2025
JBorrow
reviewed
Oct 7, 2025
JBorrow
reviewed
Oct 7, 2025
JBorrow
reviewed
Oct 7, 2025
Member
|
Thank you! I will begin testing this. |
|
A poke on this @JBorrow @farhadcomp @plaplant ... is the review possible to go forward given failed tests above? Is something being done to increase the coverage of the unit tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new table for completed transfers to track information about start time, end time, bandwidth etc. This adds support for both local transfers and globus transfers.
Fixes #109