Use CStr::from_bytes_until_nul for safer string conversion#437
Use CStr::from_bytes_until_nul for safer string conversion#437
Conversation
buf_to_string previously used CStr::from_ptr which scans past the buffer if it is not null-terminated. Switch to CStr::from_bytes_until_nul which is bounded by the buffer length and returns an error if no null terminator is found. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
Summary
buf_to_stringusedCStr::from_ptrwhich scans for a null terminator without any bounds check — if the buffer is not null-terminated it reads past the endCStr::from_bytes_until_nulwhich is bounded by the buffer length and returns an error if no null terminator is foundTest plan
🤖 Generated with Claude Code