Conversation
…nvention create_image and fetch_hdu_info reverse dimensions to present them in C row-major order, but read_region and write_region were passing ranges directly to CFITSIO without reversing. This caused the ranges to be interpreted with swapped axes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis pull request adjusts how image region reading and writing operations interpret user-provided ranges to align with CFITSIO's Fortran column-major convention. User-provided ranges are specified in C row-major order [rows, columns], but the implementation now reverses the iteration order to correctly handle the underlying column-major data layout. Test expectations and comments are updated accordingly to reflect this coordinate system interpretation change. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
Summary
create_imageandfetch_hdu_inforeverse dimensions to present them in C row-major order, butread_regionandwrite_regionwere passing ranges directly to CFITSIO without reversingTest plan
read_region/write_regionnow use consistent row-major axis ordering withcreate_image/fetch_hdu_info🤖 Generated with Claude Code