Stdev eclipse t1191 test libc cipher and coin

.Doxyfile

@@ -5,7 +5,7 @@
 #---------------------------------------------------------------------------
 DOXYFILE_ENCODING      = UTF-8
 PROJECT_NAME           = libskycoin
-PROJECT_NUMBER         = 0.24.1-develop
+PROJECT_NUMBER         = 0.25.0-rc1-develop
 PROJECT_BRIEF          = "Skycoin C client library"
 PROJECT_LOGO           = ./docs/assets/sky.libc.jpg
 OUTPUT_DIRECTORY       = ./docs/libc

.gitignore

@@ -102,6 +102,8 @@ electron/node_modules
 electron/.gox_output
 electron/.electron_output
 electron/.standalone_output
+electron/.daemon_output
+electron/.cli_output
 # Do not ignore the icons folder
 !electron/build
 !electron/build/icons

.travis.yml

@@ -7,12 +7,12 @@ go:
 matrix:
   include:
     - os: linux
-      env: VERSION_UPGRADE_TEST_WAIT_TIMEOUT=5s
+      env: VERSION_UPGRADE_TEST_WAIT_TIMEOUT=45s
     - os: osx
       # Do not start osx build for PR
       if: type != pull_request
       osx_image: xcode8
-      env: VERSION_UPGRADE_TEST_WAIT_TIMEOUT=30s
+      env: VERSION_UPGRADE_TEST_WAIT_TIMEOUT=60s
 
 before_install:
   - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test && sudo apt-get update -qq; fi
@@ -48,8 +48,9 @@ install:
   - cd $GOPATH/src/github.com/skycoin/skycoin
   - go get -t ./...
   - make install-linters
-  - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo apt-get install -qq g++-6 && sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-6 90; fi
-  - if [[ "$TRAVIS_OS_NAME" == "osx" ]];   then brew update ; echo 'Available versions (gcc)' && brew list --versions gcc ; brew list gcc@6 &>/dev/null || brew install gcc@6 ; fi
+  # Install pinned golangci-lint, overriding the latest version install by make install-linters
+  - VERSION=1.10.2 ./ci-scripts/install-golangci-lint.sh
+  - ./ci-scripts/install-travis-gcc.sh
   - make install-deps-libc
   - nvm install 8.11.0
   - nvm use 8.11.0

CHANGELOG.md

@@ -11,15 +11,24 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 In the v0.26.0 these features and functions will be removed.  If you have a need for any of these features, let us know.
 
 - JSON-RPC 2.0 interface (this is no longer used by the CLI tool, and the REST API supports everything the JSON-RPC 2.0 API does). See https://github.com/skycoin/skycoin/blob/develop/src/api/README.md#migrating-from-the-jsonrpc-api
-- `/api/v1/wallet/spend` endpoint (use `POST /api/v1/wallet/transaction` followed by `POST /api/v1/injectTransaction` instead)
-- The unversioned REST API (the `-enable-unversioned-api` option will be removed, prefix your API requests with `/api/v1`)
+- `/api/v1/wallet/spend` endpoint (use `POST /api/v1/wallet/transaction` followed by `POST /api/v1/injectTransaction` instead). See https://github.com/skycoin/skycoin/blob/develop/src/api/README.md#migrating-from--api-v1-spend
+- The unversioned REST API (the `-enable-unversioned-api` option will be removed, prefix your API requests with `/api/v1`). See https://github.com/skycoin/skycoin/blob/develop/src/api/README.md#migrating-from-the-unversioned-api
+- `/api/v1/explorer/address` endpoint (use `GET /api/v1/transactions?verbose=1` instead). See https://github.com/skycoin/skycoin/blob/develop/src/api/README.md#migrating-from--api-v1-explorer-address
+
+### Notice
+
+Nodes v0.23.0 and earlier will not be able to connect to v0.25.0 due to a change in the introduction packet message.
+
+Nodes v0.24.1 and earlier will not be able to connect to v0.26.0 due to a similar change.
+
+Make sure to upgrade to v0.25.0 so that your node will continue to connect once v0.26.0 is released.
 
 ### Added
 
 - Add `-csv` option to `cli send` and `cli createRawTransaction`, which will send coins to multiple addresses defined in a csv file
 - Add `-disable-default-peers` option to disable the default hardcoded peers and mark all cached peers as untrusted
 - Add `-custom-peers-file` to load peers from disk. This peers file is a newline separate list of `ip:port` strings
-- Add `csrf_enabled`, `csp_enabled`, `wallet_api_enabled`, `unversioned_api_enabled`, `gui_enabled` and `json_rpc_enabled` configuration settings to the `/api/v1/health` endpoint response
+- Add `user_agent`, `coin`, `csrf_enabled`, `csp_enabled`, `wallet_api_enabled`, `unversioned_api_enabled`, `gui_enabled` and `json_rpc_enabled`, `coinhour_burn_factor` configuration settings to the `/api/v1/health` endpoint response
 - Add `verbose` flag to `/api/v1/block`, `/api/v1/blocks`, `/api/v1/last_blocks`, `/api/v1/pendingTxs`, `/api/v1/transaction`, `/api/v1/transactions`, `/api/v1/wallet/transactions` to return verbose block data, which includes the address, coins, hours and calculcated_hours of the block's transaction's inputs
 - Add `encoded` flag to `/api/v1/transaction` to return an encoded transaction
 - Add `-http-prof-host` option to choose the HTTP profiler's bind hostname (defaults to `localhost:6060`)
@@ -35,7 +44,13 @@ In the v0.26.0 these features and functions will be removed.  If you have a need
 - Go application metrics exported at `/api/v2/metrics` (API set `PROMETHEUS`) in Prometheus format
 - Add `/api/v2/wallet/recover` to recover an encrypted wallet by providing the seed
 - Add `fiberAddressGen` CLI command to generate distribution addresses for fiber coins
-- Coinhour burn factor can be configured at runtime with `COINHOUR_BURN_FACTOR` envvar
+- Coinhour burn factor when creating transactions can be configured at runtime with `USER_BURN_FACTOR` envvar
+- Max transaction size when creating transactions can be configured at runtime with `MAX_USER_TXN_SIZE` envvar
+- Daemon configured builds will be available on the [releases](https://github.com/skycoin/skycoin/releases) page. The builds available for previous versions are configured for desktop client use.
+- `skycoin-cli` builds will be available on the [releases](https://github.com/skycoin/skycoin/releases) page.
+- A user agent string is sent in the wire protocol's introduction packet
+- `-max-connections` option to control total max connections
+- `/api/v1/network/disconnect` to disconnect a peer
 
 ### Fixed
 
@@ -49,6 +64,7 @@ In the v0.26.0 these features and functions will be removed.  If you have a need
 - `POST /api/v1/wallet/newAddress` and `POST /api/v1/wallet/spend` will correctly fail if the wallet is not encrypted but a password is provided
 - Return `503` error for `/api/v1/injectTransaction` for all message broadcast failures (note that it is still possible for broadcast to fail but no error to be returned, in certain conditions)
 - Fixed autogenerated HTTPS certs. Certs are now self-signed ECDSA certs, valid for 10 years, valid for localhost and all public interfaces found on the machine. The default cert and key are renamed from cert.pem, key.pem to skycoind.cert, skycoind.key
+- `/api/v1/resendUnconfirmedTxns` will return `503 Service Unavailable` is no connections are available for broadcast
 
 ### Changed
 
@@ -68,11 +84,24 @@ In the v0.26.0 these features and functions will be removed.  If you have a need
 - `cli addressGen` arguments have changed
 - `cli generateWallet` renamed to `cli walletCreate`
 - `cli generateAddresses` renamed to `cli walletAddAddresses`
+- `/api/v1/explorer/address` is deprecated in favor of `/api/v1/transactions?verbose=1`
+- `/api/v1/balance`, `/api/v1/transactions`, `/api/v1/outputs` and `/api/v1/blocks` accept the `POST` method so that large request bodies can be sent to the server, which would not fit in a `GET` query string
+- Send new `DISC` disconnect packet to peer before disconnecting
+- `/api/v1/health` `"open_connections"` value now includes incoming connections. Added `"outgoing_connections"` and `"incoming_connections"` fields to separate the two.
+- `run.sh` is now `run-client.sh` and a new `run-daemon.sh` script is added for running in server daemon mode
+- `/api/v1/network/connection*` connection object's field `"introduced"` replaced with field `"state"` which may have the values `"pending"`, `"connected"` or `"introduced"`
+- `/api/v1/network/connection*` field `"is_trusted_peer"` added to connection object to indicate if the peer is in the hardcoded list of default peers
+- `/api/v1/network/connection*` field `"connected_at"` added to connection object
+- `/api/v1/network/connections` now includes incoming connections. Filters are added to query connections by state and direction
+- `/api/v1/resendUnconfirmedTxns` is now a `POST` method, previously was a `GET` method
+- Transactions that violation soft constraints will propagate through the network
+- Node will send more peers before disconnecting due to a full peer list
 
 ### Removed
 
 - Remove `USE_CSRF` envvar from the CLI tool. It uses the REST API client now, which will automatically detect CSRF as needed, so no additional configuration is necessary.  Operators may still wish to disable CSRF on their remote node to reduce request overhead.
 - Remove `-enable-wallet-api` and `-enable-seed-api` in place of including `WALLET` and `INSECURE_WALLET_SEED` in `-enable-api-sets`.
+- Copies of the source code removed from release builds due to build artifact size
 
 ## [0.24.1] - 2018-07-30
 
@@ -382,7 +411,7 @@ In the v0.26.0 these features and functions will be removed.  If you have a need
 - #383 Error during installation from skycoin source code
 - #375 Node can't recovery from zero connections
 - #376 Explorer api `/explorer/address` does not return spend transactions
-- #373 Master node will be closed if there're no transactions need to execute
+- #373 Block publisher node will be closed if there're no transactions need to execute
 - #360 Node will crash when do ctrl+c while downloading blocks
 - #350 Wallet name always 'undefined' after loading wallet from seed
 

INSTALLATION.md

@@ -53,16 +53,16 @@ In China, use `--source=https://github.com/golang/go` to bypass firewall when fe
 gvm install go1.4 --source=https://github.com/golang/go
 gvm use go1.4
 
-gvm install go1.10.2
-gvm use go1.10.2 --default
+gvm install go1.11.1
+gvm use go1.11.1 --default
 ```
 
 #### Installation issues
 If you open up new a terminal and the `go` command is not found then add this to `.bashrc`. GVM should add this automatically.
 
 ```sh
 [[ -s "$HOME/.gvm/scripts/gvm" ]] && source "$HOME/.gvm/scripts/gvm"
-gvm use go1.10.2 >/dev/null
+gvm use go1.11.1 >/dev/null
 ```
 
 ## Install Go manually
@@ -72,7 +72,7 @@ Let's go to home directory and declare `go`'s version that you want to download.
 
 ```sh
 cd ~
-export GOV=1.10.2 # golang version
+export GOV=1.11.1 # golang version
 ```
 
 After that, let's download and uncompress golang source.

INTEGRATION.md

@@ -32,6 +32,7 @@ and to use the CLI tool for wallet operations (seed and address generation, tran
 
 <!-- MarkdownTOC autolink="true" bracket="round" levels="1,2,3,4,5,6" -->
 
+- [Running the skycoin node](#running-the-skycoin-node)
 - [API Documentation](#api-documentation)
 	- [Wallet REST API](#wallet-rest-api)
 	- [Skycoin command line interface](#skycoin-command-line-interface)
@@ -67,6 +68,9 @@ and to use the CLI tool for wallet operations (seed and address generation, tran
 
 <!-- /MarkdownTOC -->
 
+## Running the skycoin node
+
+For integrations, the skycoin node should be run from source with `./run-daemon.sh`. This requires go1.10+ to be installed.
 
 ## API Documentation
 

Makefile

@@ -23,6 +23,7 @@ BUILDLIB_DIR = $(BUILD_DIR)/libskycoin
 LIB_DIR = lib
 LIB_FILES = $(shell find ./lib/cgo -type f -name "*.go")
 SRC_FILES = $(shell find ./src -type f -name "*.go")
+HEADER_FILES = $(shell find ./include -type f -name "*.h")
 BIN_DIR = bin
 DOC_DIR = docs
 INCLUDE_DIR = include
@@ -61,8 +62,11 @@ else
   LDFLAGS=$(LIBC_FLAGS)
 endif
 
-run:  ## Run the skycoin node. To add arguments, do 'make ARGS="--foo" run'.
-	./run.sh ${ARGS}
+run-client:  ## Run skycoin with desktop client configuration. To add arguments, do 'make ARGS="--foo" run'.
+	./run-client.sh ${ARGS}
+
+run-daemon:  ## Run skycoin with server daemon configuration. To add arguments, do 'make ARGS="--foo" run'.
+	./run-daemon.sh ${ARGS}
 
 run-help: ## Show skycoin node help
 	@go run cmd/$(COIN)/$(COIN).go --help
@@ -90,21 +94,23 @@ configure-build:
 	mkdir -p $(BUILD_DIR)/usr/tmp $(BUILD_DIR)/usr/lib $(BUILD_DIR)/usr/include
 	mkdir -p $(BUILDLIB_DIR) $(BIN_DIR) $(INCLUDE_DIR)
 
-$(BUILDLIB_DIR)/libskycoin.so: $(LIB_FILES) $(SRC_FILES)
+$(BUILDLIB_DIR)/libskycoin.so: $(LIB_FILES) $(SRC_FILES) $(HEADER_FILES)
 	rm -Rf $(BUILDLIB_DIR)/libskycoin.so
 	go build -buildmode=c-shared  -o $(BUILDLIB_DIR)/libskycoin.so $(LIB_FILES)
 	mv $(BUILDLIB_DIR)/libskycoin.h $(INCLUDE_DIR)/
 
-$(BUILDLIB_DIR)/libskycoin.a: $(LIB_FILES) $(SRC_FILES)
+$(BUILDLIB_DIR)/libskycoin.a: $(LIB_FILES) $(SRC_FILES) $(HEADER_FILES)
 	rm -Rf $(BUILDLIB_DIR)/libskycoin.a
 	go build -buildmode=c-archive -o $(BUILDLIB_DIR)/libskycoin.a  $(LIB_FILES)
 	mv $(BUILDLIB_DIR)/libskycoin.h $(INCLUDE_DIR)/
 
+## Build libskycoin C static library
 build-libc-static: $(BUILDLIB_DIR)/libskycoin.a
 
+## Build libskycoin C shared library
 build-libc-shared: $(BUILDLIB_DIR)/libskycoin.so
 
-## Build libskycoin C client library
+## Build libskycoin C client libraries
 build-libc: configure-build build-libc-static build-libc-shared
 
 ## Build libskycoin C client library and executable C test suites
@@ -209,20 +215,33 @@ build-ui:  ## Builds the UI
 build-ui-travis:  ## Builds the UI for travis
 	cd $(GUI_STATIC_DIR) && npm run build-travis
 
-release: ## Build electron and standalone apps. Use osarch=${osarch} to specify the platform. Example: 'make release osarch=darwin/amd64', multiple platform can be supported in this way: 'make release osarch="darwin/amd64 windows/amd64"'. Supported architectures are: darwin/amd64 windows/amd64 windows/386 linux/amd64 linux/arm, the builds are located in electron/release folder.
+release: ## Build electron, standalone and daemon apps. Use osarch=${osarch} to specify the platform. Example: 'make release osarch=darwin/amd64', multiple platform can be supported in this way: 'make release osarch="darwin/amd64 windows/amd64"'. Supported architectures are: darwin/amd64 windows/amd64 windows/386 linux/amd64 linux/arm, the builds are located in electron/release folder.
 	cd $(ELECTRON_DIR) && ./build.sh ${osarch}
 	@echo release files are in the folder of electron/release
 
-release-bin: ## Build standalone apps. Use osarch=${osarch} to specify the platform. Example: 'make release-bin osarch=darwin/amd64' Supported architectures are the same as 'release' command.
+release-standalone: ## Build standalone apps. Use osarch=${osarch} to specify the platform. Example: 'make release-standalone osarch=darwin/amd64' Supported architectures are the same as 'release' command.
 	cd $(ELECTRON_DIR) && ./build-standalone-release.sh ${osarch}
 	@echo release files are in the folder of electron/release
 
-release-gui: ## Build electron apps. Use osarch=${osarch} to specify the platform. Example: 'make release-gui osarch=darwin/amd64' Supported architectures are the same as 'release' command.
+release-electron: ## Build electron apps. Use osarch=${osarch} to specify the platform. Example: 'make release-electron osarch=darwin/amd64' Supported architectures are the same as 'release' command.
 	cd $(ELECTRON_DIR) && ./build-electron-release.sh ${osarch}
 	@echo release files are in the folder of electron/release
 
-clean-release: ## Clean dist files and delete all builds in electron/release
-	rm $(ELECTRON_DIR)/release/*
+release-daemon: ## Build daemon apps. Use osarch=${osarch} to specify the platform. Example: 'make release-daemon osarch=darwin/amd64' Supported architectures are the same as 'release' command.
+	cd $(ELECTRON_DIR) && ./build-daemon-release.sh ${osarch}
+	@echo release files are in the folder of electron/release
+
+release-cli: ## Build CLI apps. Use osarch=${osarch} to specify the platform. Example: 'make release-cli osarch=darwin/amd64' Supported architectures are the same as 'release' command.
+	cd $(ELECTRON_DIR) && ./build-cli-release.sh ${osarch}
+	@echo release files are in the folder of electron/release
+
+clean-release: ## Remove all electron build artifacts
+	rm -rf $(ELECTRON_DIR)/release
+	rm -rf $(ELECTRON_DIR)/.gox_output
+	rm -rf $(ELECTRON_DIR)/.daemon_output
+	rm -rf $(ELECTRON_DIR)/.cli_output
+	rm -rf $(ELECTRON_DIR)/.standalone_output
+	rm -rf $(ELECTRON_DIR)/.electron_output
 
 clean-coverage: ## Remove coverage output files
 	rm -rf ./coverage/