x86 f16: implement rounding support#1380
x86 f16: implement rounding support#1380TheNumbat wants to merge 3 commits intosimd-everywhere:masterfrom
Conversation
|
Some errors from Microsoft Visual Studio 2015 version 19.00.24241.7 and Visual Studio 2017 version 19.16.27035: https://ci.appveyor.com/project/nemequ/simde/builds/53462546/job/ya2shs5yojpisa31#L4688 |
mr-c
force-pushed
the
f16-rounding
branch
2 times, most recently
from
9e8035c to
234fb23
Compare
|
Hmm, this is weird. It's rounding |
|
The only difference from 19.14 to 19.20 (which gives the expected answer) seems to be some spills: https://godbolt.org/z/Y59G5vK65 |
|
Actually, it appears they changed |
|
I just removed the test since signed nan handling already differs between targets |
mr-c
force-pushed
the
f16-rounding
branch
2 times, most recently
from
42721ff to
7963426
Compare
Assumes `_MM_FROUND_CUR_DIRECTION` is always half-to-even, which isn't strictly correct, but is already assumed by various other functions.
Head branch was pushed to by a user without write access
|
Looks like the Azure CI pipeline started timing out? |
|
@TheNumbat I will rebase this PR once #1384 is merged |
2 participants
Makes
_mm_cvtps_ph/_mm256_cvtps_phrespect the rounding mode argument. Assumes_MM_FROUND_CUR_DIRECTIONis always half-to-even, which isn't strictly correct, but is already assumed by various other functions.Enables the rounding mode tests and adds a few more. There should be no behavior changes for the round-nearest and round-current cases.