Skip to content

silx.gui.plot: Improved StatsWidget display slightly, especially for 1D plots #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flowln wants to merge 3 commits into from
Closed

silx.gui.plot: Improved StatsWidget display slightly, especially for 1D plots #4361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cce125
fix(StatsWidget): improve rendering of CoM and Std in 1D plots
flowln Jul 31, 2025
b87c130
fix(StatsWidget): set stretch on last column for occupying the entire…
flowln Jul 31, 2025
25cb49f
fix(StatsWidget): align all values to the center of the column
flowln Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/silx/gui/plot/StatsWidget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,8 @@ def setStats(self, statsHandler):
horizontalHeader = self.horizontalHeader()
horizontalHeader.setSectionResizeMode(qt.QHeaderView.ResizeToContents)

horizontalHeader.setStretchLastSection(True)
Copy link
Copy Markdown
Member

@payno payno Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


self._updateItemObserve()

def setPlot(self, plot):
Expand Down Expand Up @@ -817,6 +819,7 @@ def _addItem(self, item):
for column, tableItem in enumerate(tableItems):
tableItem.setData(qt.Qt.UserRole, _Container(item))
tableItem.setFlags(qt.Qt.ItemIsEnabled | qt.Qt.ItemIsSelectable)
tableItem.setTextAlignment(qt.Qt.AlignHCenter | qt.Qt.AlignVCenter)
Copy link
Copy Markdown
Member

@payno payno Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

self.setItem(row, column, tableItem)

# Update table items content
Expand Down
6 changes: 4 additions & 2 deletions src/silx/gui/plot/stats/statshandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,8 @@ def calculate(
data_changed=data_changed,
roi_changed=roi_changed,
)
for resName, resValue in list(res.items()):
res[resName] = self.format(resName, res[resName])
for resName, resValue in res.items():
if isinstance(resValue, tuple) and len(resValue) == 1:
resValue = resValue[0]
Comment on lines +220 to +222
Copy link
Copy Markdown
Member

@payno payno Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with this approach is that we won't be able to display tuples as results of stats. But we need it.
For example with 2D or 3D data, we expect the StatCoordMin method to return a tuple of values—and that’s precisely what we want to show to the user.

image

The simplest alternative is probably to create you own StatCoordMin that would return a scalar instead of a tuple like

class MyStatCoordMin(StatCoordMin):
    def calculate(self, context):
        result = super().calculate(context)
        return result[0]

Copy link
Copy Markdown
Contributor Author

@flowln flowln Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I added the check len(resValue) == 1, so that it is specific to 1D values. Though in 2D+ cases, perhaps the best approach would be to change the format method to also check if the value is a tuple or a list even when self.formatters[name] is None, so we can call str on each individual element anyway, and get rid of the np.floatXY text.

Copy link
Copy Markdown
Member

@payno payno Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The StatsHandler.calculate function only delegates the calculation of the result.
Similarly, StatsHandler.format simply delegates to the formatter associated with the Stats object. This way we maintain a certain separation of concerns.

Given the current design, I think there are two approaches to address your use case:

  • Use the default formatter and ensure your stats return a scalar value, as demonstrated in the MyStatCoordMin example.

  • Provide a custom formatter as you suggested. This approach might be more involved. An example is given in examples/plotStats.py. And you can define the stats to be computed with it (formatter)[https://docs.python.org/3.9/library/formatter.html].
    For example if I resume the example with StatCoordMin you would have something like

    plot = Plot2D()

    stats = [
        (StatCoordMin(), "{0:.2f}"),
    ]

    plot.getStatsWidget().setStats(stats)

res[resName] = self.format(resName, resValue)
return res
Loading