switch to PySide6==6.7.3 and force dpi to 96 for windows#1182
switch to PySide6==6.7.3 and force dpi to 96 for windows#1182sergey-yaroslavtsev wants to merge 3 commits intomasterfrom
Conversation
|
I fail to see if you are fixing things (versions, resolutions) everywhere or just for the frozen binaries. |
|
|
Thanks. Point 1 is what I wanted to make sure it was applied. Concerning Point 2, prior to decide the scale, I guess one should check the Desktop resolution. Unless I have missed something, the issue is mainly with the ROI Imaging Tool main window on laptops -not necessarily on windows-. That issue is not there when those laptops are docked or in desktop computers. Did I get it right? Decisions based on desktop size instead of platform are also at other places in the code. For instance on FitParam.py to prevent the buttons of the fit configuration window from being outside the screen when the vertical resolution is less than 801 pixels (i.e. decision independent of OS but dependent on desktop resolution). |
Almost every module in PyMca can be executed on its own with a generic path: python -m PyMca5.PyMca.FitParam FitParam is part of the configuration window of the XRF fit. |
|
I still think that with a big desktop resolution, any scaling will work and therefore it should not be necessary to touch things. I would condition what you are doing to having a small desktop vertical resolution (1024 pixels or less?) |
|
Is there opened issues on this in matplotlib? how does silx view behaves in similar conditions? |
From what i see (please correct me if you have different experience) the scaling will anyway break "matplolib fonts". I am doing test with my current display (2560x1440 27 inches).
Scaling indeed will change detectable resolution, so we can "allow small scaling" but not sure (just personal subjective taste) it is good idea. But if you think it is better this way a can agree. Matplotlib fonts still will be ruined but other fonts will not be so small maybe for some people it is crucial... |
|
It seems the risk to break something playing with the scaling is higher than facing the current situation. |
|
sorry i freeze it via Ci there was compatibility issue with 6.7.3.
Not really sure but does it make any sense to make it optional and save the choice to PyMca.ini? Of course it will require restart of the software to change the option - so some warning window can appear. I am personally never using the scale - because it breaks not only PyMca but many things... From this perspective Windows users could be familiar with this issue. |
|
@sergey-yaroslavtsev thanks for the checks | matplotlib fonts are also weird If there's twice antialiasing applied on text, no surprise it looks ugly. | Probably require an issue to be created. Definitely, we'll check it for silx: silx-kit/silx#4480 |
fd348c7 to
e2819d2
Compare






Closes #1179

Hopefully there are no other visual bugs... There is no possible automatic test for it unfortunately as it does not break functionality.
Forcing to remove scale factor for Windows can look ugly but I could not find any better solution. The only problem which will appear because of it is that fonts on high DPI screens will be small.
I tested 6.7.3 via local builds as shown in initial issue.
And for DPI local run (before after with scale 150%):