Skip to content

BUGFIX: Use logger instead of print#5

Merged
jonochang merged 1 commit intomasterfrom
sh/use-logger-for-mqtt-message
Jan 30, 2025
Merged

BUGFIX: Use logger instead of print#5
jonochang merged 1 commit intomasterfrom
sh/use-logger-for-mqtt-message

Conversation

@simon-dev-ml
Copy link
Collaborator

No description provided.

@simon-dev-ml simon-dev-ml self-assigned this Jan 23, 2025
@jonochang jonochang changed the base branch from master to all-non-upstreamed-changes January 23, 2025 23:09
@jonochang jonochang changed the base branch from all-non-upstreamed-changes to master January 23, 2025 23:11
@jonochang
Copy link
Member

jonochang commented Jan 28, 2025

I've created a PR upstream at geekscape#31

once that is merged in we can probably close this PR.

In the meantime we can add to all-non-upstreamed-changes branch (#3)

@jonochang jonochang force-pushed the sh/use-logger-for-mqtt-message branch from d8f87e8 to 100ea96 Compare January 30, 2025 23:33
@jonochang jonochang merged commit 21b60f3 into master Jan 30, 2025
@jonochang jonochang deleted the sh/use-logger-for-mqtt-message branch January 30, 2025 23:39
@jonochang jonochang restored the sh/use-logger-for-mqtt-message branch February 2, 2025 23:32
@geekscape
Copy link
Member

I have dealt with the Aiko Services upstream Pull Request #31
Note: For reasons unknown the upstream Pull Request geekscape#31 was closed, before I even saw it 🤔

Fixed by Improve "src/aiko_services/main/pipeline.py" replacing "print()" with "self.logger()" (commit 32042d4)

  • Replaced all pipeline.py print() statements with self.logger...() statements

@geekscape
Copy link
Member

I have also dealt with the duplicate Aiko Services upstream Pull Request #33

Note; It would have been more efficient to just re-open the existing PR#31 😅

@jonochang jonochang changed the title Use logger instead of print BUGFIX: Use logger instead of print Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants