Removing admin site from urls.py - second attempt (requires #677)#679
Open
adamcharnock wants to merge 21 commits intosilverapp:masterfrom
Open
Removing admin site from urls.py - second attempt (requires #677)#679adamcharnock wants to merge 21 commits intosilverapp:masterfrom
adamcharnock wants to merge 21 commits intosilverapp:masterfrom
Conversation
Happy to re-add formatting later, I just need to know which tool you used to do it. Also, maybe we'll move to poetry.
…rce_str()
Warning was:
RemovedInDjango40Warning: force_text() is deprecated in favor of force_str().
Warning was:
MigrationNotice: `XXX.filter_class` attribute should be renamed `filterset_class`. See: https://django-filter.readthedocs.io/en/master/guide/migration.html
Warning was:
RemovedInDjango40Warning: django.conf.urls.url() is deprecated in favor of django.urls.re_path().
Warning was:
RemovedInDjango40Warning: django.utils.translation.ugettext_lazy() is deprecated in favor of django.utils.translation.gettext_lazy().
…s fix)
Warning was:
RemovedInDjango40Warning: django.conf.urls.url() is deprecated in favor of django.urls.re_path().
…ting uses to reflect this
JWT library now requires the `algorithms` parameter to be specified when decoding. Silver uses the default algorithm when encoding (HS256), so I specified that for the decoding.
…ango 3. Making it longer.
NullBooleanField is deprecated. Support for it (except in historical migrations) will be removed in Django 4.0. HINT: Use BooleanField(null=True) instead. Adding migration for this and previous change to JSONField default values
?: (admin.W411) 'django.template.context_processors.request' must be enabled in DjangoTemplates (TEMPLATES) in order to use the admin navigation sidebar.
…json objects. Note added to CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second attempt of #678.
In this case I have built this change upon the larger PR #677.
The
silver.urlsfile is the one which should be imported by developers. There is now also asilver.urls_projectwhich should be used when running silver as a standalone project (e.g. when running silver's tests).Useful diff visible here