SF-3835 Do not allow uploading training data when offline#3985
Open
pmachapman wants to merge 1 commit into
Open
SF-3835 Do not allow uploading training data when offline#3985pmachapman wants to merge 1 commit into
pmachapman wants to merge 1 commit into
Conversation
pmachapman
added
the
will require testing
Contributor
|
📸 Screenshot diff deployed! (1 change) View the visual diff at: https://pr-3985--sf-screenshot-diffs.netlify.app |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3985 +/- ##
=======================================
Coverage 81.02% 81.03%
=======================================
Files 644 644
Lines 41445 41450 +5
Branches 6726 6751 +25
=======================================
+ Hits 33580 33587 +7
+ Misses 6770 6768 -2
Partials 1095 1095 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than changing the error message, I took the same approach as the chapter audio dialog and disabled uploading when offline
This change is