Skip to content

SF-3840 Alert user that available drafting books reflect source text #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RaymondLuong3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SF-3840 Alert user that available drafting books reflect source text #3977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...p/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,9 @@ <h4 class="explanation">
</div>
</app-notice>
}
@if (unusableTranslateTargetBooks.length) {
<app-notice>
<transloco key="draft_generation_steps.unusable_target_books"></transloco>
</app-notice>
}
<app-notice>
{{ t("draft_book_unavailable", { sourceProjectName: draftingSourceProjectName }) }}
</app-notice>
@if (showBookSelectionError) {
<app-notice type="error">
{{ t("choose_books_to_translate_error") }}
Expand Down
3 changes: 1 addition & 2 deletions ...ranslate/draft-generation/draft-generation-steps/draft-generation-steps.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,8 +396,7 @@ describe('DraftGenerationStepsComponent', () => {
expect(component.trainingBooksExcludingTranslatedWithoutEnoughData).toEqual([5]);
}));

it('should set "unusableTranslateTargetBooks" and "unusableTrainingTargetBooks" correctly', fakeAsync(() => {
expect(component.unusableTranslateTargetBooks).toEqual([7]);
it('should set "unusableTrainingTargetBooks" correctly', fakeAsync(() => {
expect(component.unusableTrainingTargetBooks).toEqual([7]);
}));

Expand Down
4 changes: 0 additions & 4 deletions ...app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ export class DraftGenerationStepsComponent implements OnInit {

// Unusable books do not exist in the target or corresponding drafting/training source project
unusableTranslateSourceBooks: number[] = [];
unusableTranslateTargetBooks: number[] = [];
emptyTranslateSourceBooks: number[] = [];
trainingBooksExcludingTranslatedWithoutEnoughData: number[] = [];
unusableTrainingSourceBooks: number[] = [];
Expand Down Expand Up @@ -378,9 +377,6 @@ export class DraftGenerationStepsComponent implements OnInit {
this.unusableTrainingTargetBooks = [...trainingSourceBooks].filter(
bookNum => !targetBooks.has(bookNum) && Canon.isCanonical(bookNum)
);
this.unusableTranslateTargetBooks = [...draftingSourceBooks].filter(
bookNum => !targetBooks.has(bookNum) && Canon.isCanonical(bookNum)
);

// set developer settings
if (this.featureFlags.showDeveloperTools.enabled) {
Expand Down
2 changes: 1 addition & 1 deletion src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/non_checking_en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@
"configure_advanced_settings_title": "Advanced settings",
"confirm_codes_correct_to_continue": "Please confirm the language codes are correct before continuing",
"custom_configurations_apply": "Custom draft configurations have been applied by an administrator.",
"draft_book_unavailable": "Can't find the book you're looking for? Be sure the book exists in your drafting source text ({{ sourceProjectName }}).",
"email_me": "Email me at {{ email }} when the draft is finished.",
"fast_training_warning": "Enabling this will save time but greatly reduce accuracy.",
"fast_training": "Enable Fast Training",
Expand Down Expand Up @@ -276,7 +277,6 @@
"training_files": "Training files",
"translated_book_selected_no_training_pair": "Some of the training books you selected have no matching reference books selected. Please select matching reference books.",
"translated_books": "Translated books",
"unusable_target_books": "Can't find the book you're looking for? Be sure the book is created in Paratext, then sync your project.",
"use_echo_warning": "Enabling this will echo your source text instead of translating it.",
"use_echo": "Use Echo Translation Engine"
},
Expand Down
Loading