Skip to content

Add missing error messages to onboarding form #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nateowami wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −1
Open

Add missing error messages to onboarding form #3831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...src/app/translate/draft-generation/draft-signup-form/draft-onboarding-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ <h1>{{ t("title") }}</h1>
formControlName="translationLanguageName"
[placeholder]="t('translation_language_name_placeholder')"
/>
@if (signupForm.controls.translationLanguageName.hasError("required")) {
<mat-error>{{ t("translation_language_name_required") }}</mat-error>
}
</mat-form-field>
</div>

Expand All @@ -80,6 +83,9 @@ <h1>{{ t("title") }}</h1>
formControlName="translationLanguageIsoCode"
[placeholder]="t('translation_language_iso_placeholder')"
/>
@if (signupForm.controls.translationLanguageIsoCode.hasError("required")) {
<mat-error>{{ t("translation_language_iso_required") }}</mat-error>
}
</mat-form-field>
</div>

Expand Down
4 changes: 3 additions & 1 deletion src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/non_checking_en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,8 +972,10 @@
"title": "Sign up for draft generation",
"translation_language_iso_label": "Translation language ISO code",
"translation_language_iso_placeholder": "e.g. swa, tpi",
"translation_language_iso_required": "Translation language ISO code is required",
"translation_language_name_label": "Translation language name",
"translation_language_name_placeholder": "e.g. Swahili, Tok Pisin"
"translation_language_name_placeholder": "e.g. Swahili, Tok Pisin",
"translation_language_name_required": "Translation language name is required"
},
"users": {
"collaborators": "Collaborators",
Expand Down
Loading