Skip to content

Properly handle average confidence for translation jos with no pretranslations #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enkidu93 merged 1 commit into from
Jul 2, 2026
Merged

Properly handle average confidence for translation jos with no pretranslations #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Serval/src/Serval.Translation/Services/PlatformService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ public async Task InsertPretranslationsAsync(
int nextModelRevision = engine.ModelRevision + 1;

var batch = new List<Pretranslation>();
double confidenceTotal = 0.0;
double totalConfidence = 0.0;
int numPretranslations = 0;
await foreach (PretranslationContract item in pretranslations.WithCancellation(cancellationToken))
{
Expand Down Expand Up @@ -404,7 +404,7 @@ public async Task InsertPretranslationsAsync(
Confidence = item.Confidence,
}
);
confidenceTotal += item.Confidence ?? 0.0;
totalConfidence += item.Confidence ?? 0.0;
numPretranslations += 1;
if (batch.Count == PretranslationInsertBatchSize)
{
Expand All @@ -417,7 +417,11 @@ public async Task InsertPretranslationsAsync(

await _builds.UpdateAsync(
b => b.Id == buildId,
u => u.Set(b => b.ExecutionData.AveragePretranslationConfidence, confidenceTotal / numPretranslations),
u =>
u.Set(
b => b.ExecutionData.AveragePretranslationConfidence,
numPretranslations > 0 ? totalConfidence / numPretranslations : 0.0
),
cancellationToken: cancellationToken
);
}
Expand Down
16 changes: 15 additions & 1 deletion src/Serval/test/Serval.Translation.Tests/Services/PlatformServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,27 @@ await env.Builds.InsertAsync(
Assert.That(env.Pretranslations.Count, Is.EqualTo(1));
await env.PlatformService.BuildCompletedAsync("b0", 0, 0.0);
Assert.That(env.Pretranslations.Count, Is.EqualTo(1));

await env.PlatformService.BuildStartedAsync("b0");
await env.PlatformService.InsertPretranslationsAsync("e0", "b0", GetTestPretranslations());
await env.PlatformService.BuildCompletedAsync("b0", 0, 0.0);
Assert.That(env.Pretranslations.Count, Is.EqualTo(1));
Assert.That(
(await env.Builds.GetAsync(b => b.Id == "b0"))?.ExecutionData.AveragePretranslationConfidence,
Is.Zero
Is.Zero.Within(0.001)
);

await env.PlatformService.BuildStartedAsync("b0");
await env.PlatformService.InsertPretranslationsAsync(
"e0",
"b0",
AsyncEnumerable.Empty<PretranslationContract>()
);
await env.PlatformService.BuildCompletedAsync("b0", 0, 0.0);
Assert.That(env.Pretranslations.Count, Is.EqualTo(0));
Assert.That(
(await env.Builds.GetAsync(b => b.Id == "b0"))?.ExecutionData.AveragePretranslationConfidence,
Is.Zero.Within(0.001)
);
}

Expand Down
Loading