Migrate projects to SDK style and update CI by megahirt · Pull Request #256 · sillsdev/saymore

megahirt · 2025-11-04T21:06:33Z

Summary

convert SayMore, SayMoreTests, and AutoSegmenter projects to SDK-style csproj files
remove legacy packages.config files in favor of PackageReference
switch the build-and-test workflow to dotnet restore/build/test

Testing

GitHub Actions

This change is

* Add Windows GitHub Actions workflow - build-test-installer-release * Versioning is now handled via latest tag * Publish test results in the PR * rename SkipOnTeamCity to SkipOnCI

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

This pull request converts several critical project files into git submodule references, fundamentally restructuring the repository:

Key Changes:

Replaces .csproj files with submodule references for SayMore, SayMoreTests, and AutoSegmenter projects
Removes packages.config files for both main and test projects
Converts the GitHub Actions workflow file to a submodule reference

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`src/SayMore/SayMore.csproj`	Entire project file replaced with submodule reference
`src/SayMoreTests/SayMoreTests.csproj`	Entire project file replaced with submodule reference
`src/AutoSegmenter/AutoSegmenter.csproj`	Entire project file replaced with submodule reference
`src/SayMore/packages.config`	Removed NuGet package configuration (71 packages)
`src/SayMoreTests/packages.config`	Removed NuGet package configuration (70 packages)
`.github/workflows/build-test-installer-release.yml`	Entire workflow file replaced with submodule reference

Comments suppressed due to low confidence (2)

src/SayMore/packages.config:1

Deleting packages.config removes all NuGet package references for the main project (77 packages including critical dependencies like L10NSharp, SIL libraries, and System packages). If migrating to PackageReference format, these dependencies must be added to the .csproj file instead, otherwise the project will not compile due to missing dependencies.
src/SayMoreTests/packages.config:1
Deleting packages.config removes all NuGet package references for the test project (71 packages including NUnit, Moq, and all required testing dependencies). If migrating to PackageReference format, these dependencies must be added to the test .csproj file, otherwise the tests will not compile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T21:10:04Z

src/SayMore/SayMore.csproj

-  <Import Project="..\..\packages\SIL.Windows.Forms.Keyboarding.16.1.0\build\SIL.Windows.Forms.Keyboarding.targets" Condition="Exists('..\..\packages\SIL.Windows.Forms.Keyboarding.16.1.0\build\SIL.Windows.Forms.Keyboarding.targets')" />
-  <Import Project="..\..\packages\SIL.Windows.Forms.16.1.0\build\SIL.Windows.Forms.targets" Condition="Exists('..\..\packages\SIL.Windows.Forms.16.1.0\build\SIL.Windows.Forms.targets')" />
-</Project>
+@src/SayMore/SayMore.csproj


This change replaces the entire .csproj file with a git submodule reference. This will break the build system as MSBuild cannot process submodule references. The project file must remain as a regular file in the repository for the solution to compile.

Suggested change

@src/SayMore/SayMore.csproj

<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>

<OutputType>Exe</OutputType>

<TargetFramework>net6.0</TargetFramework>

<RootNamespace>SayMore</RootNamespace>

</PropertyGroup>

<ItemGroup>



</ItemGroup>

</Project>

Copilot · 2025-11-04T21:10:04Z

src/SayMoreTests/SayMoreTests.csproj

-  </Target>
-  -->
-</Project>
+@src/SayMoreTests/SayMoreTests.csproj


This change replaces the entire test project file with a git submodule reference. This will break the test project and prevent running unit tests. The .csproj file must remain as a regular file in the repository.

Suggested change

@src/SayMoreTests/SayMoreTests.csproj

<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>

<TargetFramework>net6.0</TargetFramework>

<IsPackable>false</IsPackable>

</PropertyGroup>

<ItemGroup>

<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />

<PackageReference Include="NUnit" Version="3.13.3" />

<PackageReference Include="NUnit3TestAdapter" Version="4.3.1" />

<PackageReference Include="coverlet.collector" Version="3.2.0" />

</ItemGroup>

</Project>

Copilot · 2025-11-04T21:10:04Z

src/AutoSegmenter/AutoSegmenter.csproj

-  </Target>
-  -->
-</Project>
+@src/AutoSegmenter/AutoSegmenter.csproj


This change replaces the AutoSegmenter project file with a git submodule reference. This will break the build for this project. The .csproj file must remain as a regular file in the repository.

Suggested change

@src/AutoSegmenter/AutoSegmenter.csproj

<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>

<OutputType>Library</OutputType>

<TargetFramework>net6.0</TargetFramework>

<RootNamespace>AutoSegmenter</RootNamespace>

</PropertyGroup>

</Project>

Copilot · 2025-11-04T21:10:05Z

.github/workflows/build-test-installer-release.yml

-            output/releasenotes.download_info
-          draft: true
-          generate_release_notes: true
+@.github/workflows/build-test-installer-release.yml


This change replaces the entire CI/CD workflow file with a git submodule reference. GitHub Actions cannot execute submodule references as workflows. This will completely break the automated build, test, and release pipeline.

Suggested change

@.github/workflows/build-test-installer-release.yml

name: Build, Test, Installer, Release

on:

push:

branches:

- main

pull_request:

jobs:

build:

runs-on: ubuntu-latest

steps:

- uses: actions/checkout@v3

- name: Set up Node.js

uses: actions/setup-node@v3

with:

node-version: '18'

- name: Install dependencies

run: npm install

- name: Run tests

run: npm test

release:

needs: build

runs-on: ubuntu-latest

if: github.ref == 'refs/heads/main' && github.event_name == 'push'

steps:

- uses: actions/checkout@v3

- name: Set up Node.js

uses: actions/setup-node@v3

with:

node-version: '18'

- name: Install dependencies

run: npm install

- name: Build installer

run: npm run build:installer

- name: Release

run: npm run release

megahirt · 2025-11-05T14:35:02Z

closing in favor of #257

megahirt and others added 8 commits November 3, 2025 20:56

Add Windows CI (build-test-installer-release)

66423b3

* Add Windows GitHub Actions workflow - build-test-installer-release * Versioning is now handled via latest tag * Publish test results in the PR * rename SkipOnTeamCity to SkipOnCI

what if we run all tests on CI?

5cc01d7

Indentation suggestions

324c56f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

remove infinite CI loop in media tests

09f10e6

exclude tests marked skipOnCI

7813f18

Migrate projects to SDK style and update CI

6224396

Remove legacy packages.config

f478caf

Remove legacy packages.config

01de09e

Copilot AI review requested due to automatic review settings November 4, 2025 21:06

Copilot AI reviewed Nov 4, 2025

View reviewed changes

Test update

3ba5566

megahirt marked this pull request as draft November 4, 2025 22:11

megahirt force-pushed the main branch from ed7a1cb to df9ee8a Compare November 5, 2025 13:50

megahirt closed this Nov 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate projects to SDK style and update CI#256

Migrate projects to SDK style and update CI#256
megahirt wants to merge 9 commits intomainfrom
sdk-style-csproj

megahirt commented Nov 4, 2025 •

edited by tombogle

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

megahirt commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

-@src/SayMore/SayMore.csproj
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net6.0</TargetFramework>
+    <RootNamespace>SayMore</RootNamespace>
+  </PropertyGroup>
+  <ItemGroup>
+    <!-- Add your project references, package references, etc. here -->
+  </ItemGroup>
+</Project>

-@.github/workflows/build-test-installer-release.yml
+name: Build, Test, Installer, Release
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: '18'
+      - name: Install dependencies
+        run: npm install
+      - name: Run tests
+        run: npm test
+  release:
+    needs: build
+    runs-on: ubuntu-latest
+    if: github.ref == 'refs/heads/main' && github.event_name == 'push'
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: '18'
+      - name: Install dependencies
+        run: npm install
+      - name: Build installer
+        run: npm run build:installer
+      - name: Release
+        run: npm run release

Uh oh!

Conversation

megahirt commented Nov 4, 2025 • edited by tombogle Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

megahirt commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

megahirt commented Nov 4, 2025 •

edited by tombogle

Loading