Buttons not in last segment if segment less than 0.5 seconds#118
Open
phillip-hopper wants to merge 1 commit intomasterfrom
Open
Buttons not in last segment if segment less than 0.5 seconds#118phillip-hopper wants to merge 1 commit intomasterfrom
phillip-hopper wants to merge 1 commit intomasterfrom
Conversation
Also fixed floating point errors that started happening after updating Windows and Visual Studio
Collaborator
|
I wonder if this is the desired behavior? I now recall having a discussion with @hatton (years back) and deciding that if the user left a small segment at the end that it was most likely just final cruft in the recording and would not need to be annotated. Now that we've decided that a valid segment can be less than 0.5 seconds, maybe we want to adjust the threshold for this as well, but still leave that logic in place. But maybe that was a bad decision, given Sarah's feedback. |
tombogle
requested changes
Sep 30, 2020
| public bool GetIsAcceptableSegmentLength(float start, float end) | ||
| { | ||
| return end - start >= Settings.Default.MinimumSegmentLengthInMilliseconds / 1000f; | ||
| return Math.Round(end * 1000 - start * 1000) >= Settings.Default.MinimumSegmentLengthInMilliseconds; |
Collaborator
There was a problem hiding this comment.
What sort of error was occurring? If this is the necessary fix, probably a comment is needed, lest it be put back later by someone wishing to make it more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed floating point errors that started happening after updating Windows and Visual Studio
This change is