+semver:minor Add PalasoImage robust helper default overrides (BL-16221)#1499
+semver:minor Add PalasoImage robust helper default overrides (BL-16221)#1499andrew-polk wants to merge 1 commit into
Conversation
And expand the exception types which are retried
tombogle
left a comment
There was a problem hiding this comment.
@tombogle reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on andrew-polk).
SIL.Windows.Forms/ImageToolbox/PalasoImage.cs line 377 at r1 (raw file):
// Again you'd expect that if it's corrupt, it would stay that way, but // experimentally, it seems we can get this if the file can't be read because it is (temporarily?) locked. // (The text of the message reads, "File could not be read and is possible corrupted", which
typo: possibly
Since you're there, you probably should also capitalize "experimentally"
JohnThomson
left a comment
There was a problem hiding this comment.
@JohnThomson reviewed all commit messages and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on andrew-polk).
SIL.Windows.Forms/ImageToolbox/PalasoImage.cs line 416 at r1 (raw file):
int maxRetryAttempts = RetryUtility.kDefaultMaxRetryAttempts, int retryDelay = RetryUtility.kDefaultRetryDelay, HashSet<Type> retryOnExceptions = null)
I would be inclined to make this additionalRetryOnExceptions, and union it with the three we already know are likely. Is there any reason we would NOT want to include the types we already know can be a problem? So it makes life easier for the client, and also, a client will automatically benefit from any further ones that get added to the library.
JohnThomson
left a comment
There was a problem hiding this comment.
One suggestion, but if you don't think it's a good idea,
@JohnThomson reviewed 3 files and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on andrew-polk).
And expand the exception types which are retried
This change is