Fix dashboard stats assignment_value_stale warnings

[hahn-kev]

Summary

• Replace assignment-expression arrow callbacks on dashboard writing-system row fields with patch helpers that use Object.assign.
• Use block-bodied callbacks for top-level dashboard stat assignments to avoid Svelte assignment_value_stale runtime warnings in the browser console.

Fixes the warnings in the console:

[svelte] assignment_value_staleAssignment to `definition` property (src/​​project/​​dashboard/​​dashboard-stats.svelte.ts:78:74) 
will evaluate to the right-hand side, not the value of `definition` following the assignment.
This may result in unexpected behaviour.https://svelte.dev/e/assignment_value_stale

Test plan

• Open the project dashboard in Fw Lite viewer
• Confirm writing-system completion stats still load progressively
• Verify the browser console no longer shows assignment_value_stale warnings from dashboard-stats.svelte.ts

Made with Cursor

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a4875dcc-cd08-437e-8a22-61af84e13dab

📥 Commits

Reviewing files that changed from the base of the PR and between 0f35616 and 0524afd.

📒 Files selected for processing (1)

• frontend/viewer/src/project/dashboard/dashboard-stats.svelte.ts

---

📝 Walkthrough

Walkthrough

Adds two private helper methods to DashboardStats that patch vernacular and analysis rows by wsId using Object.assign. Updates the load method's primary count assignments to block-form callbacks and reroutes per-writing-system field updates through the new patch helpers instead of direct row mutation.

Changes

Dashboard Stats Patch Helpers

Layer / File(s)	Summary
Row patching helpers and load wiring frontend/viewer/src/project/dashboard/dashboard-stats.svelte.ts	Adds #patchVernacularRow and #patchAnalysisRow private methods that find a row by wsId and apply partial field patches via Object.assign; updates load's primary count callbacks to block-form assignments and reroutes per-writing-system lexemeForm/citationForm/exampleSentence/gloss/definition updates through the new helpers instead of mutating row directly.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• sillsdev/languageforge-lexbox#2397: Both PRs work on the same dashboard stats row/count update logic in dashboard-stats.svelte.ts.
• sillsdev/languageforge-lexbox#2407: Both PRs touch the same file's stats loading and row-update flow with related patch/load logic.

Poem

A rabbit patches row by row,
No more direct mutation, watch it go!
By wsId we find our place,
Object.assign, a tidy embrace 🐇
Hop along, the stats now glow.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: fixing dashboard stats assignment_value_stale warnings.
Description check	✅ Passed	The description accurately matches the code changes and test plan for fixing the Svelte warning.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/fix-dashboard-assignment-value-stale

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Jul 7, 2026, 12:57 PM