Skip to content

Add variant editing to the FwLite viewer#2409

Closed
myieye wants to merge 2 commits into
feat/variants-backendfrom
feat/variants-ui
Closed

Add variant editing to the FwLite viewer#2409
myieye wants to merge 2 commits into
feat/variants-backendfrom
feat/variants-ui

Conversation

@myieye

@myieye myieye commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Stacked on #2408. Adds "Variant of" and "Variants" fields to the entry editor (both views, shown by default), with a per-link "Variant type" checkbox menu on each link badge; new links default to Unspecified Variant like FLEx. Edits flow through updateEntry, so the demo project works unchanged; Playwright covers both directions plus the type toggle.

HideMinorEntry/Comment are modeled+synced (backend PR) but deliberately have no editor UI yet.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1efd2471-7018-47ad-bad1-289525e2c0b5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/variants-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Jul 4, 2026
@myieye myieye force-pushed the feat/variants-ui branch from 4738cbe to 3ef2378 Compare July 4, 2026 13:38
@myieye myieye force-pushed the feat/variants-backend branch from 4722098 to a5a336f Compare July 4, 2026 13:38
myieye and others added 2 commits July 4, 2026 16:05
Variant of / Variants entry fields with per-link variant-type menu, demo data
seed, i18n strings, Playwright coverage. New variants default to Unspecified
Variant like FLEx.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@myieye myieye force-pushed the feat/variants-ui branch from 3ef2378 to 3517b56 Compare July 4, 2026 14:05
@myieye

myieye commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by the iterative review workflow: the UI step will be re-opened as a cumulative PR (backend + UI) against develop so it gets CI and full reviews. Backend step review completed in #2408.

@myieye myieye closed this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant