Add FLEx-compatible per-writing-system collation to FwLite#2406
Draft
hahn-kev wants to merge 3 commits into
Draft
Add FLEx-compatible per-writing-system collation to FwLite#2406hahn-kev wants to merge 3 commits into
hahn-kev wants to merge 3 commits into
Conversation
Persist compiled ICU rules and system locale on WritingSystem, extract them when mapping fwdata, sync into the CRDT, and add an EF migration. Collation is import-only via the fwdata update proxy; fix collation cache poisoning during mid-migration schema upgrades. Co-authored-by: Cursor <cursoragent@cursor.com>
Register ICU-backed collators in DI, initialize ICU in FwLiteWeb, and apply custom collation in SetupCollationInterceptor with Unicode tie-break sorting. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace icu.net/libpalaso collators in LcmCrdt with managed ICU4N adapters so custom writing-system collation works on Android. Seed the example project's German vernacular with reversed A/B ICU rules for manual testing. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IcuCollationRules,SystemCollationLocale) onWritingSystem, with EF migration and import-only sync from fwdataIWritingSystemCollatorProvider&b < a &B < Ademo ICU rules for manual testingTest plan
dotnet test backend/FwLite/LcmCrdt.Tests --filter "FullyQualifiedName~WritingSystemCollatorProvider|FullyQualifiedName~CustomCollationSorting|FullyQualifiedName~CanCreateExampleProject"dotnet test backend/FwLite/MiniLcm.Tests --filter "FullyQualifiedName~WritingSystemSync"Banane, Beere, Apfel, ...without crashNotes
ch) may differ slightly from FLExICU4N.Resourcesadds ~18MB; considerSatelliteResourceLanguageson FwLiteMaui in a follow-up if APK size is a concern