Bump SIL.Harmony to 0.2.1-rc.211 and adopt generic remote-resource types#2402
Bump SIL.Harmony to 0.2.1-rc.211 and adopt generic remote-resource types#2402myieye wants to merge 3 commits into
Conversation
Harmony PR #75 made RemoteResource / ResourceService / IRemoteResourceService / change classes generic on TMetadata. We pick NoMetadata (marker type — lexbox media has no synced metadata today). EF migration adds a nullable Metadata jsonb column; existing rows get NULL. Wire discriminators preserved (delete:RemoteResource etc.), old payloads round-trip with Metadata=null. AddRemoteResourceEntity<NoMetadata>() stays in ConfigureCrdt (behind a RemoteResourcesEnabled guard) so bare CrdtConfig callers — TypeGen, HistoryService.AllChangeTypes, LcmDebugger — still see the resource entity. DI order: AddCrdtRemoteResources runs first so its Configure delegate flips the guard before ConfigureCrdt sees it.
|
Warning Review limit reached
Next review available in: 21 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (17)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
💻 FW Lite
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Two Devin findings on #2402: - ConfigRegistrationTests: DeleteChange<RemoteResource<NoMetadata>> is now constructible but unregistered (replaced by DeleteRemoteResourceChange). Add to _excludedChangeTypes. - UseChangesTests: DeleteRemoteResourceChange<NoMetadata> and SetRemoteResourceMetadataChange<NoMetadata> weren't in GetAllChanges(). Add both, chained off createRemoteResourceChange.
|
Actually this is already mostly done in #2358 |
|
OK oops. I actually just wanted to patch the missing commit-metadata and this was a blocker. |
2 participants
Harmony PR sillsdev/harmony#75 made
RemoteResource,ResourceService,IRemoteResourceService, and the resource change classes generic onTMetadata. We pickNoMetadata— lexbox media has no synced metadata today. EF migration adds a nullableMetadatajsonb column; existing rows getNULL. Wire discriminators are preserved (delete:RemoteResourceetc.); legacy payloads round-trip withMetadata: null.AddRemoteResourceEntity<NoMetadata>()stays inConfigureCrdt(behind aRemoteResourcesEnabledguard) so bare-CrdtConfigcallers — TypeGen,HistoryService.AllChangeTypes,LcmDebugger— still see the resource entity + change types. DI order matters:AddCrdtRemoteResourcesis registered first so its Configure delegate flips the guard beforeConfigureCrdtruns.Follow-up (separate PR, on top of #2393): plumb
CommitMetadatainto theResourceServicecalls so media commits get author attribution the same wayCrdtMiniLcmApidoes.Notes:
0.2.1-rc.211is an untaggedmain-branch prerelease from sillsdev/harmony, consistent with how we pinnedrc.202.NoMetadatabecomes wire-breaking for older clients — not this PR's concern, but this bump opens that door.Test plan
LcmCrdt.Testsverified snapshots (12 pass) — includesDataModelSnapshotTests,ChangeSerializationTests.RegressionDataUpToDate,MigrationTests,SnapshotDeserializationTestsFwLiteProjectSync.Testsverified snapshots (2 pass)dotnet build backend/FwLite/FwLiteShared/FwLiteShared.csproj— no generated-TS drift