Delete unused ReplaceComplexFormTypeChange

[myieye]

Seems to me that we can/should delete this...

Dead code: never registered in LcmCrdtKernel, never constructed anywhere — complex-form-type replacement already works via Remove+Add. Flagged in review of #2388.

🤖 Generated with Claude Code

https://claude.ai/code/session_01YX1riHKjttP2Eemy2ji6uS

---

Generated by Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 14460e78-8727-46fa-ae7c-6b625ebc159d

📥 Commits

Reviewing files that changed from the base of the PR and between c35a7f6 and c902da4.

📒 Files selected for processing (2)

• backend/FwLite/LcmCrdt.Tests/ConfigRegistrationTests.cs
• backend/FwLite/LcmCrdt/Changes/Entries/ReplaceComplexFormTypeChange.cs

💤 Files with no reviewable changes (2)

• backend/FwLite/LcmCrdt/Changes/Entries/ReplaceComplexFormTypeChange.cs
• backend/FwLite/LcmCrdt.Tests/ConfigRegistrationTests.cs

---

📝 Walkthrough

Walkthrough

ReplaceComplexFormTypeChange class is deleted entirely. The ConfigRegistrationTests removes the corresponding exclusion from _excludedChangeTypes and drops the now-unused using LcmCrdt.Changes.Entries import.

Changes

Remove ReplaceComplexFormTypeChange

Layer / File(s)	Summary
Delete change class and update test exclusions backend/FwLite/LcmCrdt/Changes/Entries/ReplaceComplexFormTypeChange.cs, backend/FwLite/LcmCrdt.Tests/ConfigRegistrationTests.cs	ReplaceComplexFormTypeChange is removed; ConfigRegistrationTests drops the exclusion entry and unused using directive.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• sillsdev/languageforge-lexbox#1796: Directly modified ReplaceComplexFormTypeChange.cs to handle duplicate/deleted-type logic — the same file this PR removes.

Suggested reviewers

• rmunn
• hahn-kev

🐇 A class once hopped through the code with flair,
Replacing complex forms with utmost care.
But the rabbit said, "Snip! We don't need this today,"
And deleted the file and hopped away.
The tests now agree — less code, hooray! 🎉

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the unused ReplaceComplexFormTypeChange code.
Description check	✅ Passed	The description is directly related to deleting the unused change class and explains why it can be removed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/loving-sagan-e2zksn

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Jun 30, 2026, 7:55 AM