Skip to content

Fix missing search bar in find-word and find-related-words webviews#2387

Merged
imnasnainaec merged 1 commit into
developfrom
pb-ext-fix-missing-search-bar
Jun 30, 2026
Merged

Fix missing search bar in find-word and find-related-words webviews#2387
imnasnainaec merged 1 commit into
developfrom
pb-ext-fix-missing-search-bar

Conversation

@imnasnainaec

@imnasnainaec imnasnainaec commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Fixing a regression from the Tailwind update in #2333

Summary

  • SearchBar's tw:@container/search wrapper sets container-type: inline-size, which collapses to zero width in a flex context without an explicit width — making the <input> invisible
  • Add tw:w-full to the wrapper div and isFullWidth to SearchBar in both affected webviews
  • Mirrors the fix applied to the paranext-core dictionary component in c63af4e205

Test plan

  • Open "Search in lexicon" webview — search text field is visible
  • Open "Find related words in lexicon" webview — search text field is visible
  • Search still functions correctly in both webviews

🤖 Generated with Claude Code

Devin: https://app.devin.ai/review/sillsdev/languageforge-lexbox/pull/2387

SearchBar's tw:@container/search wrapper sets container-type: inline-size,
which collapses to zero width in a flex context without an explicit width.
Add tw:w-full to the wrapper div and isFullWidth to SearchBar — mirrors the
fix applied to the paranext-core dictionary component in c63af4e205.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Two web view components (find-related-words and find-word) have their SearchBar header layout updated: the wrapper div gains tw:w-full and the SearchBar component receives the isFullWidth prop.

Changes

SearchBar Full-Width Layout

Layer / File(s) Summary
Full-width SearchBar in find views
platform.bible-extension/src/web-views/find-related-words.web-view.tsx, platform.bible-extension/src/web-views/find-word.web-view.tsx
Wrapper divs add tw:w-full and SearchBar receives isFullWidth prop in both find web views.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

🟨Medium

Suggested reviewers

  • jasonleenaylor

Poem

🐰 A SearchBar stretched wide, edge to edge it goes,
tw:w-full declared, the full-width layout flows,
isFullWidth passed, the prop lands just right,
Two tiny files changed, keeping layouts tight.
The rabbit hops on—such a tidy delight! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: fixing the missing search bar in the two webviews.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description matches the code changes and explains the same search bar width fix in both webviews.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pb-ext-fix-missing-search-bar

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@imnasnainaec imnasnainaec self-assigned this Jun 29, 2026
@myieye

myieye commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Can you maybe show us what your "find related words" UI looks like? You presumably have more experience than us for that feature, so I'm just curious 😁

@imnasnainaec imnasnainaec merged commit 57b77e9 into develop Jun 30, 2026
3 checks passed
@imnasnainaec imnasnainaec deleted the pb-ext-fix-missing-search-bar branch June 30, 2026 15:03
@imnasnainaec

Copy link
Copy Markdown
Collaborator Author

@myieye It copies the style of the core's Hebrew/Greek dictionary.

Screenshot 2026-06-30 110939 Screenshot 2026-06-30 110956 Screenshot 2026-06-30 111009 Screenshot 2026-06-30 111032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants