3 -> 2 notion requests / second#80
Open
dionjwa wants to merge 1 commit into
Open
Conversation
|
|
Member
|
@dionjwa, thanks for doing that research. If the info in your link is correct, (2700 API calls over a 15 minute period) then we should be able to change the rate-limiting algorithm to match that? |
Member
|
Related, a blog post covering various limits: https://notionmastery.com/pushing-notion-to-the-limits/ |
Member
|
In case you have time to try this out, it seems that we could use the same |
Member
|
Later, I realized that while that change might speed up operations, it shouldn't improve anything. I did some work making docu-notion more resilient to timeouts. That is now PR #81. Even with no timeout at all, it was able to handle docs.BloomLibrary.org. |
jellejurre
added a commit
to jellejurre/docu-notion
that referenced
this pull request
Mar 22, 2024
jellejurre
added a commit
to jellejurre/docu-notion
that referenced
this pull request
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am running from the
mainbranch, and I am constantly getting 502s. According to the notion docs, rate limit requests should be429(https://developers.notion.com/reference/request-limits) but I suspect that their API is not perfect, and returns 502s instead a lot of the time.Anecdotally, someone claims that the limit is 3/requests per second. As this value is set in
docu-notionI can imagine that due to network, randomness, having the set limit be exactly their internal limit would mean that sometimes you skirt over the edge.https://www.reddit.com/r/Notion/comments/xfufed/how_do_you_handle_request_limits_using_notion_api/
I have found that setting it to 2 greatly reduces the 502 timeout/rate limit issues.
This change is