Skip to content

Add Indonesian UI#4319

Draft
imnasnainaec wants to merge 9 commits into
masterfrom
id2
Draft

Add Indonesian UI#4319
imnasnainaec wants to merge 9 commits into
masterfrom
id2

Conversation

@imnasnainaec

@imnasnainaec imnasnainaec commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Also remove unnecessary ../ added to image paths in non-English user guide pages. They are now automatically resolved by mkdocs.

Devin: https://app.devin.ai/review/sillsdev/TheCombine/pull/4319

This change is Reviewable

Summary by CodeRabbit

  • New Features

    • Added Indonesian language support across the app and site.
    • Expanded the user guide with new Indonesian pages for account, project, data entry, and data cleanup workflows.
  • Documentation

    • Updated multiple translated guides so screenshots load correctly in all supported languages.
    • Added a new Indonesian documentation index and admin guide.
  • Bug Fixes

    • Fixed several translated messages so placeholder text displays consistently.

@imnasnainaec imnasnainaec self-assigned this Jul 2, 2026
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a47ed99c-8fe0-4bb8-9cd3-e0b675be9c11

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds Indonesian (id) localization: a new translation.json catalog, writingSystem entry, README badge update, and MkDocs i18n/search/alternate config. Adds five new Indonesian user guide pages (index, account, admin, dataEntry, goals, project). Updates image paths in existing es/zh user guide pages and fixes a placeholder whitespace typo across several locale files.

Changes

Indonesian UI localization enablement

Layer / File(s) Summary
Writing system and translation catalog
src/types/writingSystem.ts, public/locales/id/translation.json, README.md
Adds Bcp47Code.Id to uiWritingSystems, introduces the full Indonesian translation catalog, and updates the README localization badge.
Interpolation placeholder fix
public/locales/ar/..., en/..., es/..., pt/..., zh/translation.json
Removes extra whitespace inside the {{ val2 }} placeholder in findAndReplaceError across five locale files.

Indonesian user guide pages and mkdocs configuration

Layer / File(s) Summary
MkDocs Indonesian config
docs/user_guide/mkdocs.yml
Adds id language navigation mapping, search language, and /id/ alternate entry.
Index and account pages
docs/user_guide/docs/index.id.md, account.id.md
New Indonesian index page and account guide covering registration, login, and settings.
Admin page
docs/user_guide/docs/admin.id.md
New Indonesian admin guide covering project management and banner configuration.
Data entry page
docs/user_guide/docs/dataEntry.id.md
New Indonesian data entry guide covering entry creation and duplicate handling.
Goals page
docs/user_guide/docs/goals.id.md
New Indonesian data cleanup guide covering review, merge, and spell-check features.
Project page
docs/user_guide/docs/project.id.md
New Indonesian project guide covering settings, languages, users, and statistics.

Existing user guide image path updates (es/zh)

Layer / File(s) Summary
Account/Admin/DataEntry image paths
account.es.md, account.zh.md, admin.es.md, admin.zh.md, dataEntry.es.md, dataEntry.zh.md
Screenshot references changed from ../images/... to images/....
Goals/Project image paths
goals.es.md, goals.zh.md, project.es.md, project.zh.md
Screenshot references updated to images/... with occasional {.center} formatting adjustments.

Estimated code review effort: 2 (Simple) | ~15 minutes

Suggested labels: 🟨Medium

Suggested reviewers: jasonleenaylor

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding Indonesian UI support.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch id2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added documentation Improvements or additions to documentation frontend font/language labels Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.96%. Comparing base (e2b613d) to head (7b0f782).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4319   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files         305      305           
  Lines       11384    11384           
  Branches     1411     1411           
=======================================
  Hits         8648     8648           
  Misses       2332     2332           
  Partials      404      404           
Flag Coverage Δ
backend 87.22% <ø> (ø)
frontend 66.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec marked this pull request as ready for review July 2, 2026 20:47

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@public/locales/id/translation.json`:
- Line 335: Fix the typo in the `deleteConfirm` translation string by correcting
the missing space in the Indonesian copy; update the value in the locale entry
so the prompt reads naturally. Locate the string via `deleteConfirm` in the
translation JSON and adjust only that text.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 061452eb-1c51-4be1-b16e-009426d51bb7

📥 Commits

Reviewing files that changed from the base of the PR and between e2b613d and 392e756.

📒 Files selected for processing (25)
  • README.md
  • docs/user_guide/docs/account.es.md
  • docs/user_guide/docs/account.id.md
  • docs/user_guide/docs/account.zh.md
  • docs/user_guide/docs/admin.es.md
  • docs/user_guide/docs/admin.id.md
  • docs/user_guide/docs/admin.zh.md
  • docs/user_guide/docs/dataEntry.es.md
  • docs/user_guide/docs/dataEntry.id.md
  • docs/user_guide/docs/dataEntry.zh.md
  • docs/user_guide/docs/goals.es.md
  • docs/user_guide/docs/goals.id.md
  • docs/user_guide/docs/goals.zh.md
  • docs/user_guide/docs/index.id.md
  • docs/user_guide/docs/project.es.md
  • docs/user_guide/docs/project.id.md
  • docs/user_guide/docs/project.zh.md
  • docs/user_guide/mkdocs.yml
  • public/locales/ar/translation.json
  • public/locales/en/translation.json
  • public/locales/es/translation.json
  • public/locales/id/translation.json
  • public/locales/pt/translation.json
  • public/locales/zh/translation.json
  • src/types/writingSystem.ts

Comment thread public/locales/id/translation.json Outdated
@imnasnainaec imnasnainaec marked this pull request as draft July 2, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation font/language frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant