Skip to content

Bump mlp; Update font script, fonts#4308

Merged
imnasnainaec merged 8 commits into
masterfrom
bump-mlp
Jun 24, 2026
Merged

Bump mlp; Update font script, fonts#4308
imnasnainaec merged 8 commits into
masterfrom
bump-mlp

Conversation

@imnasnainaec

@imnasnainaec imnasnainaec commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Devin: https://app.devin.ai/review/sillsdev/TheCombine/pull/4308


This change is Reviewable

Summary by CodeRabbit

Release Notes

  • New Features

    • Expanded font family coverage including enhanced support for diverse scripts and non-Latin writing systems.
  • Chores

    • Updated language picker dependency to version 2.7.5 and refreshed license documentation.
  • Improvements

    • Enhanced font validation to ensure all selected fonts have valid download sources.

imnasnainaec and others added 2 commits June 18, 2026 15:45
scriptFontIndex.js changed from objects with "family" fields to a flat
array of [tag, [slug, ...]] pairs. Update get_fonts_dev.py to parse the
new format and resolve slugs to family names via the bundled families.json.

Also fix check_font_info() to return False when the default file has no
download URL, allowing the fallback chain to run (e.g. charissilcompact
now falls back to charis).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@imnasnainaec, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 1 second. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1eb1718c-5100-4d56-b6e3-f2a66e22dbc8

📥 Commits

Reviewing files that changed from the base of the PR and between 73276b6 and 6969dda.

📒 Files selected for processing (2)
  • maintenance/scripts/get_fonts.py
  • scripts/get_fonts_dev.py
📝 Walkthrough

Walkthrough

Upgrades the mui-language-picker dependency from 2.6.1 to 2.7.5, updates the corresponding license entry, regenerates the font-family list with expanded and renamed entries, rewrites the --update script to parse scriptFontIndex.js as JSON via families.json, and tightens check_font_info to reject fonts whose default file lacks a download URL.

Changes

mui-language-picker 2.7.5 upgrade and font tooling

Layer / File(s) Summary
Dependency version bump and license update
package.json, docs/user_guide/assets/licenses/frontend_licenses.txt
Bumps the mui-language-picker constraint from ~2.6.1 to ~2.7.5 and updates the license entry version and copyright year range accordingly.
Expanded font family list
maintenance/scripts/mui_language_picker_fonts.txt
Regenerates the picker font list: adds non-Noto families, renames BJCree UNIBJCree, Gentium PlusGentium/Gentium Book, corrects Noto Sans SignWritingNoto Sans Sign Writing, and adds many new Noto Sans/Serif script variants throughout the file.
Font-list update script and download validation
scripts/get_fonts_dev.py, maintenance/scripts/get_fonts.py
Rewrites --update in get_fonts_dev.py to parse scriptFontIndex.js as JSON, extract slugs, map through families.json, warn on missing slugs, sort output, and fix the downstream flag from -f to -u. Adds URL presence check in check_font_info in get_fonts.py.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • sillsdev/TheCombine#4141: Performs the same mui-language-picker version bump in package.json and frontend_licenses.txt, making it a direct predecessor to this PR's upgrade.

Suggested labels

🟥High

Suggested reviewers

  • jasonleenaylor

🐇 A hop through the font list today,
New families added along the way!
Ruwudu, Akatab, all sorted just right,
The picker now shines with expanded Unicode light.
Version bumped, slugs mapped, warnings in place —
This rabbit approves of the upgrade's grace! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Bump mlp; Update font script, fonts' is vague and uses abbreviated terminology that doesn't clearly convey the scope or purpose of the changes. Consider a more descriptive title such as 'Update mui-language-picker to 2.7.5 and refactor font handling scripts' to clearly indicate the main objectives.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-mlp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added documentation Improvements or additions to documentation deployment font/language python dependencies Pull requests that update a dependency file labels Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.96%. Comparing base (69403c1) to head (6969dda).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4308   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files         305      305           
  Lines       11384    11384           
  Branches     1411     1411           
=======================================
  Hits         8648     8648           
  Misses       2332     2332           
  Partials      404      404           
Flag Coverage Δ
backend 87.22% <ø> (ø)
frontend 66.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec self-assigned this Jun 19, 2026
@imnasnainaec imnasnainaec marked this pull request as ready for review June 23, 2026 20:53
@imnasnainaec imnasnainaec added the 🟨Medium Medium-priority PR label Jun 23, 2026

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor partially reviewed 6 files and made 1 comment.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on imnasnainaec).

@imnasnainaec imnasnainaec left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imnasnainaec reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

@imnasnainaec imnasnainaec merged commit e2b613d into master Jun 24, 2026
20 checks passed
@imnasnainaec imnasnainaec deleted the bump-mlp branch June 24, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file deployment documentation Improvements or additions to documentation font/language 🟨Medium Medium-priority PR python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants