Replaced SuppressMessage attributes with PublicAPI from JetBrains.Annotations#77
Replaced SuppressMessage attributes with PublicAPI from JetBrains.Annotations#77
Conversation
…otations Deprecated AbandondedSuites in favor of correctly spelled AbandonedSuites Misc minor code refactoring and cleanup. Fixed typos in comments.
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed 15 of 26 files at r1, all commit messages.
Reviewable status: 15 of 26 files reviewed, all discussions resolved (waiting on @ermshiperete)
SIL.BuildTasks/FileUpdate.cs line 1 at r1 (raw file):
// Copyright (c) 2023 SIL Global
2023-2025
SIL.BuildTasks.AWS/S3/S3BuildPublisher.cs line 84 at r1 (raw file):
private bool ProcessFiles() { Log.LogMessage(MessageImportance.Normal, "Publishing SourceFiles={0} to {1}", Join(SourceFiles), DestinationBucket);
Is changing a log message possibly a breaking change?
SIL.BuildTasks/StampAssemblies/StampAssemblies.cs line 1 at r1 (raw file):
// Copyright (c) 2025 SIL Global
2018-2025
SIL.BuildTasks/UnitTestTasks/TestTask.cs line 1 at r1 (raw file):
// Copyright (c) 20218-2025 SIL Global
2018-2025
…-change in CHANGELOG
tombogle
left a comment
There was a problem hiding this comment.
Reviewable status: 15 of 26 files reviewed, all discussions resolved (waiting on @ermshiperete)
SIL.BuildTasks.AWS/S3/S3BuildPublisher.cs line 84 at r1 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
Is changing a log message possibly a breaking change?
I did consider that possibility. I wouldn't think so, but I'm not sure how to verify for sure.
ermshiperete
left a comment
There was a problem hiding this comment.
Reviewed 22 of 26 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tombogle)
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tombogle)
Also:
This change is