Added DeviceUILanguage application property in support of "Top 5 Devi…

[tombogle]

…ce Lang" metric

---

This change is 

[jasonleenaylor]

src/DesktopAnalytics/Analytics.cs line 234 at r1 (raw file):

			// This (and "64bit OS" above) really belong in Context, but segment.io doesn't seem
			// to convey context to Mixpanel in a reliable/predictable form.
			var ci = CultureInfo.InstalledUICulture;

Are you sure this is the right info? I would have expected CurrentCulture to be what we want.

[tombogle]

src/DesktopAnalytics/Analytics.cs line 234 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Are you sure this is the right info? I would have expected CurrentCulture to be what we want.

Pretty sure. CurrentCulture is app/thread-specific, so that can change whenever the user changes the current UI in the application. I'm adding this new property to support the request for the device language. I think our intention is to try to note the (likely) preferred locale of the user, based on the OS installation, regardless of the actual UI they might have chosen for the app. This potentially shows where we might have a hole in our UI language offerings. For example, if their OS is in German but we don't offer a German UI (or it is incredibly deficient), they might be using English against their will. More generally, noting the top device languages gives us a vague feel for the linguistic preferences of our user community, and over time, we might note trends in those preferences.

[jasonleenaylor]

@jasonleenaylor reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @hatton).