Skip to content

use typescript to generate .d.ts files#21

Open
hobbitronics wants to merge 2 commits intomainfrom
mick-generate-d.ts
Open

use typescript to generate .d.ts files#21
hobbitronics wants to merge 2 commits intomainfrom
mick-generate-d.ts

Conversation

@hobbitronics
Copy link
Contributor

EA-87 Add types to pipedream-utils for the consumer


Added

  • Add a script to generate types from the JSDocs
  • ran the script to add .d.ts files (will need to decide if we do this manually as a checklist item)

PR checklist:

  • Add (or update) tests for new (or revised) code
  • Bump version number in package.json (see semver.org).
  • Update README.md

@hobbitronics hobbitronics requested a review from a team as a code owner February 24, 2026 06:32
@hobbitronics hobbitronics requested review from briskt, ethancanne, forevermatt and mtompset and removed request for a team February 24, 2026 06:32
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it can be autogenerated. Seems like any time we have required steps that are manual, it's hard to consistently do them. Also, is this really necessary? I haven't been seeing problems in my IDE that I can recall.

@hobbitronics
Copy link
Contributor Author

I hope it can be autogenerated. Seems like any time we have required steps that are manual, it's hard to consistently do them. Also, is this really necessary? I haven't been seeing problems in my IDE that I can recall.

No, it's not completely necessary since we're likely the only ones using it an many other actions may not use TS at all. Just thought for a library it's nice. Not sure how we'd automate it though.

Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My IDE doesn't seem to know anything about the things that I import from this library via npm. Do you think that's because of the Pipedream-style version pinning my code is using in the import statement, or the lack of these .d.ts files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants