Conversation
forevermatt
reviewed
Aug 10, 2018
Contributor
forevermatt
left a comment
forevermatt
left a comment
There was a problem hiding this comment.
I don't feel like I know enough of the implications of this change to be able to give a very meaningful approval.
Would this be a bug-fix, new-feature, or major version change to mysql-backup-restore?
fillup
approved these changes
Aug 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automated postgresql-backup-restore image build on Docker Hub was failing on a wget. Looks like the wget in BusyBox is broken in Alpine 3.6. The workaround was to install the real wget with an "apk add --update ... wget". The Docker build on Docker Hub worked when I updated to Alpine 3.8. Since I based postgresql-backup-restore on mysql-backup-restore, the Alpine version update will be needed here eventually.
apache/openwhisk#3715
coreos/awscli#20