feat: implement gossipsub partial messages extension#577
Closed
jxs wants to merge 94 commits intosigp:masterfrom
Closed
feat: implement gossipsub partial messages extension#577jxs wants to merge 94 commits intosigp:masterfrom
jxs wants to merge 94 commits intosigp:masterfrom
Conversation
This started with an attempt to solve libp2p#5751 using the previous internal async-channel. After multiple ideas were discussed off band, replacing the async-channel with an internal more tailored priority queue seemed inevitable. This priority queue allows us to implement the cancellation of in flight IDONTWANT's very cleanly with the remove_data_messages function. Clearing the stale messages likewise becomes simpler as we also make use of remove_data_messages And this has the added advantage of being able to only have a single priority queue and making the code simpler. If a peer is not making progress we can assume it's not delivering High priority messages and we can penalize it.
…sipsub-partial-messages
MarcoPolo
reviewed
Sep 16, 2025
jxs
force-pushed
the
gossipsub-partial-messages
branch
5 times, most recently
from
cb0e925 to
e6f1ae4
Compare
jxs
force-pushed
the
gossipsub-partial-messages
branch
from
e6f1ae4 to
69c2d95
Compare
and create a paralel list for the partial_only topics.
jxs
force-pushed
the
gossipsub-partial-messages
branch
from
28f528d to
01b63ba
Compare
jxs
force-pushed
the
gossipsub-partial-messages
branch
from
fb46f1f to
ffd4c98
Compare
Add extra metrics for recording bytes sent and received on each topic. This will be helpful for a future PR implementing the [partial messages spec](libp2p/specs#685) Pull-Request: libp2p#6192.
jxs
force-pushed
the
gossipsub-partial-messages
branch
from
ffd4c98 to
bf1d6d7
Compare
jxs
force-pushed
the
gossipsub-partial-messages
branch
from
d995b3c to
a39b9b2
Compare
dknopik
reviewed
Feb 18, 2026
jxs
force-pushed
the
gossipsub-partial-messages
branch
5 times, most recently
from
38d449b to
a03aa97
Compare
jxs
force-pushed
the
gossipsub-partial-messages
branch
from
a03aa97 to
452e857
Compare
Member
Author
|
closing this in favor of libp2p#6275 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a draft implementation of partial messages for gossipsub following the spec PR and based on the Go implementation. Still WIP but should give a good idea of the direction we're heading.