Open
Conversation
… SDK build instructions, and improve UI for credentials and call setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces significant improvements to the
restart-iceexample, focusing on streamlining the development and testing workflow. Key changes include:signalwire.min.js) from the repository root and link it to the example.localStorageto save credentials and configurations, preventing the need to re-enter data after a page refresh.Type of Change
Related Issues
Relates to improving Developer Experience (DX) across the Relay SDK JavaScript examples.
Testing
Manual testing was performed following the new build workflow:
npm run buildwithin thepackages/jsdirectory.index.min.jstoexamples/restart-ice/signalwire.min.js.python3 -m http.server.localStorage.Checklist
Additional Notes
The interface now utilizes Bootstrap 4 to ensure a responsive layout. A troubleshooting note regarding 3rd-party cookie blocking was added, as it can affect
localStoragewhen the file is opened via thefile://protocol; using a local web server is explicitly recommended.