HYBIM-802 Updated utils APIs#348
Open
wrisa wants to merge 2 commits into
Open
Conversation
Wrap long line in test_embedding_context_manager to satisfy ruff format check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
keith-decker
approved these changes
Jun 22, 2026
keith-decker
left a comment
keith-decker
left a comment
Contributor
There was a problem hiding this comment.
LGTM, only one non blocking note from codex:
The PR changes public API guidance by marking the start_* factory methods deprecated in favor of the shorter aliases, but the package changelog's [Unreleased] section does not mention that API transition. Prior handler API work in PR 293 updated this changelog, so adding a short Changed entry would make the release notes match the public surface change.
shuningc
reviewed
Jun 22, 2026
|
|
||
| # -- Deprecated lifecycle methods ---------------------------------------- | ||
| # The following methods are preserved for backward compatibility. | ||
| # Prefer the new factory methods (start_inference, start_tool, etc.) |
Contributor
There was a problem hiding this comment.
This comment from previous PR doesn't apply any more
shuningc
reviewed
Jun 22, 2026
| server_port=server_port, | ||
| ) | ||
|
|
||
| def _start_embedding_factory( |
Contributor
There was a problem hiding this comment.
This becomes dead code and could be removed
shuningc
reviewed
Jun 22, 2026
| tool_description=tool_description, | ||
| ) | ||
|
|
||
| def _start_workflow_factory( |
Contributor
There was a problem hiding this comment.
This becomes dead code as well, can be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To match new upstream APIs,
added
inference, embedding, tool, workflowdeprecated
Note:
Not deprecating
start_agentand addinginvoke_local_agentsimilar to upstream becaset hese are not a direct equivalent. The splunk-distrostart_agentacceptsAgentCreation | AgentInvocation(supports two types) and does more work (context stack, conversation root marking, etc.), while the upstreaminvoke_local_agentis specifically forAgentInvocationwithSpanKind.INTERNAL.