Add --cluster, --sandbox, and --route-group flags to plan run#316
Merged
daniel-de-vera merged 3 commits intofeature-planfrom Apr 9, 2026
Merged
Add --cluster, --sandbox, and --route-group flags to plan run#316daniel-de-vera merged 3 commits intofeature-planfrom
daniel-de-vera merged 3 commits intofeature-planfrom
Conversation
Plans without cluster affinity now require an explicit cluster in the execution request. This adds a --cluster flag that maps to the Cluster field in PlanExecutionSpec. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Picks up the latest SDK with cluster field support in PlanExecutionSpec. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add --sandbox and --route-group mutually exclusive flags that translate to the correct plan param based on cluster affinity (FromAnyTarget for polymorphic JSON, FromSandbox/FromRouteGroup for plain strings) - Consolidate resolvePlanID + fetchPlanSpec into resolvePlan, which returns the full RunnablePlan (avoiding double fetch when using --tag) - Update go-sdk to v0.3.8-0.20260409131400-73b58199c972 for FromAnyTarget and RoutingTarget types Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
daniel-de-vera
changed the title
Contributor
Author
|
@scott-cotton, updated this PR against https://github.com/signadot/signadot/pull/6863, PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--clusterflag tosignadot plan runfor explicit cluster selection--sandboxand--route-groupmutually exclusive flags that translate to the correct plan param based on cluster affinity (FromAnyTargetfor polymorphic JSON,FromSandbox/FromRouteGroupfor plain strings)resolvePlanfunction that returns the fullRunnablePlan, avoiding a double fetch when using--tagFromAnyTarget,RoutingTarget, and related typesRelated to https://github.com/signadot/signadot/pull/6863.
Stacked on #313.
Test plan
signadot plan run --helpshows--cluster,--sandbox,--route-groupflags--sandboxand--route-groupare mutually exclusivesignadot plan run <id> --cluster <name>sends cluster in the execution requestsignadot plan run <id> --sandbox <name>sets the correct param based on plan's cluster affinitysignadot plan run <id> --route-group <name>sets the correct param based on plan's cluster affinity--sandboxon a plan withFromAnyTargetmarshals as{"sandbox": "..."}JSON--sandboxon a plan withFromSandboxsets a plain string param--sandboxon a plan with no sandbox affinity returns a clear error🤖 Generated with Claude Code