Skip to content

Conversation

@DrJKL
Copy link

@DrJKL DrJKL commented Oct 23, 2023

[K: string]: (
| number
| string
| CSS<Media, Theme, ThemeMap, Utils>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that we lose type completion on nested css objects/properties?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example where that would apply? I think line 30's member should handle most properties.

Copy link

@Pearce-Ropion Pearce-Ropion Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im talking about the nested case. Line 30 handles properties at the top of the object. I think the line you are removing handles all the nested properties.

Screenshot 2023-10-25 at 1 10 04 PM

@Pearce-Ropion
Copy link

We should probably adopt the standard publishing practices for open source repos for this repo. Typically you would land a PR that contains changes. Then make a separate PR that updates the package version. And only once that has landed, publish a new version.

That way we actually adhere to semver and are not unnecessarily publishing packages with changes that are "in-flight"

Alexander Brown added 2 commits November 21, 2023 10:41
@DrJKL DrJKL force-pushed the drjkl/tippy-tap-im-typing-away branch from 5b1b1d2 to 41e14d1 Compare November 21, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants