Skip to content

Conversation

@ColinGreybosh
Copy link
Contributor

@ColinGreybosh ColinGreybosh commented May 14, 2025

Creates a new node-embed-sdk package that contains functions to encrypt and decrypt OAuth tokens for JWT embeds on version 1.1.

Documentation forthcoming

@ColinGreybosh ColinGreybosh requested review from a team and HiranmayaGundu May 14, 2025 22:39
@ColinGreybosh ColinGreybosh self-assigned this May 14, 2025
@HiranmayaGundu
Copy link
Collaborator

You want to create a new package for this called node-embed-sdk. embed-sdk interacts with the frontend

@ColinGreybosh
Copy link
Contributor Author

You want to create a new package for this called node-embed-sdk. embed-sdk interacts with the frontend

Thank you, I pretty much just copied the project structure over from embed-sdk to make this new one.

Copy link
Collaborator

@HiranmayaGundu HiranmayaGundu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce! I think you also need a CHANGELOG.md file and a changeset or this using pnpm run changeset

EDIT: just checked my previous PRs / commits, you only need a changeset

@ColinGreybosh
Copy link
Contributor Author

NIce! I think you also need a CHANGELOG.md file and a changeset or this using pnpm run changeset

EDIT: just checked my previous PRs / commits, you only need a changeset

I think that adding a net-new package would qualify as a minor, not major, change since no existing APIs have changed, so I went ahead and added a minor changeset

Copy link
Collaborator

@HiranmayaGundu HiranmayaGundu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ColinGreybosh ColinGreybosh merged commit a0752e8 into main May 15, 2025
2 checks passed
@ColinGreybosh ColinGreybosh deleted the greybosh/token-encryption branch May 15, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants