Conversation
Ready for markdown - susanne and Zsuz
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the documentation for UX writing guidelines by introducing a new section dedicated to 'Web and application language.' It includes several new placeholder pages for topics like error pages, linking resources, onboarding, and 'what's new' dialogs, along with reordering existing documentation to integrate this new content seamlessly into the sidebar navigation. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
This is just the branch creation with the correct naming and positioning. Now ready for team to start markdown. |
There was a problem hiding this comment.
Code Review
This pull request adds new placeholder documentation pages for 'Web and application language' and adjusts the sidebar positions of existing pages. My review found a few minor structural issues in the new files. The new JSON category file should have a final newline for consistency. The new markdown pages contain an empty H1 heading, which goes against the documentation style guide that states the initial description should not have a headline. I've provided suggestions to correct these issues.
docs/guidelines/language/web-and-application-language/_category_.json
Outdated
Show resolved
Hide resolved
docs/guidelines/language/web-and-application-language/linking-resources.md
Outdated
Show resolved
Hide resolved
docs/guidelines/language/web-and-application-language/whats-new-dialogs.md
Outdated
Show resolved
Hide resolved
kathrinschalber
left a comment
There was a problem hiding this comment.
- A few minor formatting things
- Feedback regarding duplicate content from already existing chapters (where we should at least cross-link)
- Regarding the structure, you might want to reconsider the folder names - it's difficult to know what UI Wording is (since everything we do describes UI copy)
- The new UI Wording section is missing in the UX Writing overview
docs/guidelines/language/menu-functions-and-ui-labels/logging-in-and-out.md
Show resolved
Hide resolved
docs/guidelines/language/menu-functions-and-ui-labels/logging-in-and-out.md
Show resolved
Hide resolved
docs/guidelines/language/menu-functions-and-ui-labels/logging-in-and-out.md
Show resolved
Hide resolved
docs/guidelines/language/menu-functions-and-ui-labels/logging-in-and-out.md
Show resolved
Hide resolved
docs/guidelines/language/menu-functions-and-ui-labels/whats-new-announcements.md
Show resolved
Hide resolved
kathrinschalber
left a comment
There was a problem hiding this comment.
only got a tiny little finding I've missed in my first review. Rest is good to go :)
docs/guidelines/language/menu-functions-and-ui-labels/whats-new-announcements.md
Show resolved
Hide resolved
|
@danielleroux all approved - please merge, deploy and publish THANKS! |
Ready for markdown - susanne and Zsuz
💡 What is the current behavior?
GitHub Issue Number: #
🆕 What is the new behavior?
👨💻 Help & support