Conversation
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @alexkaduk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the Angular installation documentation displayed outdated peer dependency versions, potentially leading to incorrect installations. The changes update the required Angular versions to 20+ and provide a direct link to the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the Angular peer dependency versions in the documentation and adds a link to the package.json for future reference, which is a great improvement. I have one minor suggestion to align the wording with the style guide's preference for active voice.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
docs/home/installation/angular.md
Outdated
| Both `@angular/core` and `@angular/forms` are peer dependencies which means they must be installed before iX. | ||
| Both `@angular/core` and `@angular/forms` are peer dependencies that you must install before iX. | ||
|
|
||
| For the exact version requirements, see the [peerDependencies in package.json](https://github.com/siemens/ix/blob/main/packages/angular/package.json#L22-L26). |
There was a problem hiding this comment.
Linking to the exact line makes it prone to changes in the package file
There was a problem hiding this comment.
adjusted. thanks
| </BrowserOnly> | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
New line should be kept
There was a problem hiding this comment.
reverted. thanks
3 participants
💡 What is the current behavior?
The Angular installation documentation shows outdated peer dependency versions (Angular 18.2.13+) when Angular 20+ is actually required for iX v4.x.
🆕 What is the new behavior?
>=18.2.13to>=20