fix: env variable passed to the python container action#135
fix: env variable passed to the python container action#135los0220 wants to merge 2 commits intosidpalas:mainfrom
Conversation
|
Maybe it would be a good idea to show both methods with two separate variables, but that would be different from what's in the YT video. |
|
Hmm, based on the docs it should populate an env var but it might be "INPUT_WHO-TO-GREET" (only spaces get replaced with underscores, not hyphens) Mind testing that? |
|
@sidpalas I printed the env using I tested it in my forked repo: |
|
I changed the variable name to Now it works as expected: job in my repo What about shell-container-action and shell-container-action-prebuilt? Both use the env:
INPUT_WHO_TO_GREET: ${{ inputs.who-to-greet }}It's the same as in actions/container-action |
This is a fix for the issue I created #134
I added
INPUT_WHO_TO_GREETto the 06-authoring-actions/container-actions/python-container-action/action.yaml, to be properly passed to the Python container as an environmental variable.I also commented out the
argsand added comments explaining the usage of environmental variables and argument list in both action.yaml and entrypoint.py